Change initial Sockette.timer value from 1 to -1#67
Open
stevium wants to merge 1 commit intolukeed:masterfrom
Open
Change initial Sockette.timer value from 1 to -1#67stevium wants to merge 1 commit intolukeed:masterfrom
stevium wants to merge 1 commit intolukeed:masterfrom
Conversation
Since first call to window.setTimeout or window.setInterval is returning handle with ID 1 calling Sockette.close would unexpectedly clear that timeout, because timer=1 is still a valid handle ID. This commit fixes this by setting timer value to -1 which will still enable normal functionality of Sockette.reconnect, but at the same time it will not by mistake clear any other timeouts/intervals.
|
Bump Just wasted a whole bunch of time debugging because of this 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #66 by setting
timervalue to-1which would still enable normal functionality ofSockette.reconnect, but at the same time, it will not by mistake clear any other timeouts/intervals.Closes #66