fix: follow autoconf conventions for --enable/--disable help output#356
Merged
jiegec merged 1 commit intolsof-org:masterfrom Mar 13, 2026
Merged
Conversation
Use --disable-liblsof (default=yes feature) instead of --enable-liblsof and remove redundant [default=...] annotations from --enable-security and --enable-no-sock-security (default=no features). This follows the GNU convention: advertise only the option that changes behavior away from the default. Closes lsof-org#325
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--enable-liblsofto--disable-liblsofin help output (feature is enabled by default)[default=no]from--enable-securityand--enable-no-sock-securityMotivation
Per GNU autoconf conventions,
./configure --helpshould show:--disable-Xfor features that are enabled by default (user needs to know how to turn it off)--enable-Xfor features that are disabled by default (user needs to know how to turn it on)No
[default=...]annotation is needed — the option direction already communicates the default.Before:
After:
Only
configure.acis changed (4 lines). No build logic is affected — only the help text.Closes #325