Only show spinner when fetching from API

[gtsiolis]

Fix spinner UX so it only appears when actually fetching data from LocalStack, not during preliminary validation checks.

BEFORE	AFTER

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 17767c6b-b7c0-4f22-bc0f-65c7024c12a8

📥 Commits

Reviewing files that changed from the base of the PR and between 273738e and 7fe9a47.

📒 Files selected for processing (1)

• internal/container/status.go

---

📝 Walkthrough

Walkthrough

This change refactors spinner control in container status checking, moving it from global unconditional execution to targeted AWS emulator path only. The spinner now starts when beginning AWS status fetching and stops after resource fetching completes, with no spinner output for non-AWS containers.

Changes

Cohort / File(s)	Summary
Spinner Control Refactoring internal/container/status.go	Removed initial spinner start for "Fetching LocalStack status" and unconditional spinner stops on error paths. Introduced targeted spinner control for AWS emulator path only—spinner starts when fetching AWS status and stops after FetchResources completes. FetchVersion failure path no longer stops spinner explicitly. Non-AWS containers no longer trigger spinner output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: spinner control is now limited to API fetching operations only, which is the core modification in the changeset.
Description check	✅ Passed	The description is directly related to the changeset, explaining the UX improvement with before/after screenshots showing the removal of the spinner during preliminary validation checks.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch george/des-186

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}