-
Notifications
You must be signed in to change notification settings - Fork 14
add paradedb sample app #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
whummer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, kudos for churning out this sample app @HarshCasper ! 🚀
I was just having some issues running the Web app - can you please confirm if the script.js is missing in the repo, or did I miss any of the installation commands?
| } | ||
|
|
||
| const pool = new Pool({ | ||
| host: process.env.PARADEDB_HOST || "paradedb.localhost.localstack.cloud", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: General observation (also noticed this in the Wiremock sample recently) - would be great if we could avoid these "if local then ..." switches, and rather put the environment configuration at a higher level, and keep the production code free of "if local" switches as much as possible. 👍 (probably something that could be added as a general agent instruction to AGENT.md somewhere..)
| }); | ||
|
|
||
| const s3Client = new S3Client({ | ||
| endpoint: "http://s3.localhost.localstack.cloud:4566", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the above, would be great to externalize this endpoint configuration, to keep the Lambda code as close to production as possible, and only manage overrides via the environment..
|
Btw, just asked Claude for a review of the branch, just out of curiosity, and for comparison. Some of the points I've mentioned above are also included in there, and there are some additional nitpick comments (which I don't think are that important, tbh). Just wanted to share.. 🙂 👍 |
Summary
Preview