Update dependency minimatch to v10.2.3 [SECURITY]#1424
Open
renovate[bot] wants to merge 1 commit intomainfrom
Open
Update dependency minimatch to v10.2.3 [SECURITY]#1424renovate[bot] wants to merge 1 commit intomainfrom
renovate[bot] wants to merge 1 commit intomainfrom
Conversation
|
b3cc44b to
0912c23
Compare
Generated by renovateBot
0912c23 to
804db74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
10.0.3→10.2.3GitHub Vulnerability Alerts
CVE-2026-26996
Summary
minimatchis vulnerable to Regular Expression Denial of Service (ReDoS) when a glob pattern contains many consecutive*wildcards followed by a literal character that doesn't appear in the test string. Each*compiles to a separate[^/]*?regex group, and when the match fails, V8's regex engine backtracks exponentially across all possible splits.The time complexity is O(4^N) where N is the number of
*characters. With N=15, a singleminimatch()call takes ~2 seconds. With N=34, it hangs effectively forever.Details
Give all details on the vulnerability. Pointing to the incriminated source code is very helpful for the maintainer.
PoC
When minimatch compiles a glob pattern, each
*becomes[^/]*?in the generated regex. For a pattern like***************X***:When the test string doesn't contain
X, the regex engine must try every possible way to distribute the characters across all the[^/]*?groups before concluding no match exists. With N groups and M characters, this is O(C(N+M, N)) — exponential.Impact
Any application that passes user-controlled strings to
minimatch()as the pattern argument is vulnerable to DoS. This includes:.gitignore-style filtering with user-defined rulesThanks to @ljharb for back-porting the fix to legacy versions of minimatch.
CVE-2026-27904
Summary
Nested
*()extglobs produce regexps with nested unbounded quantifiers (e.g.(?:(?:a|b)*)*), which exhibit catastrophic backtracking in V8. With a 12-byte pattern*(*(*(a|b)))and an 18-byte non-matching input,minimatch()stalls for over 7 seconds. Adding a single nesting level or a few input characters pushes this to minutes. This is the most severe finding: it is triggered by the defaultminimatch()API with no special options, and the minimum viable pattern is only 12 bytes. The same issue affects+()extglobs equally.Details
The root cause is in
AST.toRegExpSource()atsrc/ast.ts#L598. For the*extglob type, the close token emitted is)*or)?, wrapping the recursive body in(?:...)*. When extglobs are nested, each level adds another*quantifier around the previous group:This produces the following regexps:
*(a|b)/^(?:a|b)*$/*(*(a|b))/^(?:(?:a|b)*)*$/*(*(*(a|b)))/^(?:(?:(?:a|b)*)*)*$/*(*(*(*(a|b))))/^(?:(?:(?:(?:a|b)*)*)*)*$/These are textbook nested-quantifier patterns. Against an input of repeated
acharacters followed by a non-matching characterz, V8's backtracking engine explores an exponential number of paths before returningfalse.The generated regex is stored on
this.setand evaluated insidematchOne()atsrc/index.ts#L1010viap.test(f). It is reached through the standardminimatch()call with no configuration.Measured times via
minimatch():*(*(a|b))ax30 +z*(*(*(a|b)))ax20 +z*(*(*(*(a|b))))ax25 +z*(a|a)ax25 +zDepth inflection at fixed input
ax16 +z:*(a|b)*(*(a|b))*(*(*(a|b)))*(*(*(*(a|b))))Going from depth 2 to depth 3 with a 20-character input jumps from 66ms to 123,544ms -- a 1,867x increase from a single added nesting level.
PoC
Tested on minimatch@10.2.2, Node.js 20.
Step 1 -- verify the generated regexps and timing (standalone script)
Save as
poc4-validate.mjsand run withnode poc4-validate.mjs:Observed output:
Step 2 -- HTTP server (event loop starvation proof)
Save as
poc4-server.mjs:Terminal 1 -- start the server:
Terminal 2 -- fire the attack (depth=3, 19 a's + z) and return immediately:
Terminal 3 -- send a benign request while the attack is in-flight:
Observed output -- Terminal 2 (attack):
Observed output -- Terminal 3 (benign, concurrent):
Terminal 1 (server log):
The server reports
"ms":"0"for the benign request -- the legitimate request itself requires no CPU time. The entire 63-secondtime_totalis time spent waiting for the event loop to be released. The benign request was only dispatched after the attack completed, confirmed by the server log timestamps.Note: standalone script timing (~7s at n=19) is lower than server timing (64s) because the standalone script had warmed up V8's JIT through earlier sequential calls. A cold server hits the worst case. Both measurements confirm catastrophic backtracking -- the server result is the more realistic figure for production impact.
Impact
Any context where an attacker can influence the glob pattern passed to
minimatch()is vulnerable. The realistic attack surface includes build tools and task runners that accept user-supplied glob arguments, multi-tenant platforms where users configure glob-based rules (file filters, ignore lists, include patterns), and CI/CD pipelines that evaluate user-submitted config files containing glob expressions. No evidence was found of production HTTP servers passing raw user input directly as the extglob pattern, so that framing is not claimed here.Depth 3 (
*(*(*(a|b))), 12 bytes) stalls the Node.js event loop for 7+ seconds with an 18-character input. Depth 2 (*(*(a|b)), 9 bytes) reaches 68 seconds with a 31-character input. Both the pattern and the input fit in a query string or JSON body without triggering the 64 KB length guard.+()extglobs share the same code path and produce equivalent worst-case behavior (6.3 seconds at depth=3 with an 18-character input, confirmed).Mitigation available: passing
{ noext: true }tominimatch()disables extglob processing entirely and reduces the same input to 0ms. Applications that do not need extglob syntax should set this option when handling untrusted patterns.CVE-2026-27903
Summary
matchOne()performs unbounded recursive backtracking when a glob pattern contains multiple non-adjacent**(GLOBSTAR) segments and the input path does not match. The time complexity is O(C(n, k)) -- binomial -- wherenis the number of path segments andkis the number of globstars. With k=11 and n=30, a call to the defaultminimatch()API stalls for roughly 5 seconds. With k=13, it exceeds 15 seconds. No memoization or call budget exists to bound this behavior.Details
The vulnerable loop is in
matchOne()atsrc/index.ts#L960:When a GLOBSTAR is encountered, the function tries to match the remaining pattern against every suffix of the remaining file segments. Each
**multiplies the number of recursive calls by the number of remaining segments. With k non-adjacent globstars and n file segments, the total number of calls is C(n, k).There is no depth counter, visited-state cache, or budget limit applied to this recursion. The call tree is fully explored before returning
falseon a non-matching input.Measured timing with n=30 path segments:
PoC
Tested on minimatch@10.2.2, Node.js 20.
Step 1 -- inline script
To scale the effect, increase k:
No special options are required. This reproduces with the default
minimatch()call.Step 2 -- HTTP server (event loop starvation proof)
The following server demonstrates the event loop starvation effect. It is a minimal harness, not a claim that this exact deployment pattern is common:
Terminal 1 -- start the server:
Terminal 2 -- send the attack request (k=11, ~5s stall) and immediately return to shell:
Terminal 3 -- while the attack is in-flight, send a benign request:
Observed output (Terminal 3):
The server reports
"ms":"0"-- the legitimate request itself takes zero processing time. The 4+ secondtime_totalis entirely time spent waiting for the event loop to be released by the attack request. Every concurrent user is blocked for the full duration of each attack call. Repeating the benign request while no attack is in-flight confirms the baseline:Impact
Any application where an attacker can influence the glob pattern passed to
minimatch()is vulnerable. The realistic attack surface includes build tools and task runners that accept user-supplied glob arguments (ESLint, Webpack, Rollup config), multi-tenant systems where one tenant configures glob-based rules that run in a shared process, admin or developer interfaces that accept ignore-rule or filter configuration as globs, and CI/CD pipelines that evaluate user-submitted config files containing glob patterns. An attacker who can place a crafted pattern into any of these paths can stall the Node.js event loop for tens of seconds per invocation. The pattern is 56 bytes for a 5-second stall and does not require authentication in contexts where pattern input is part of the feature.Release Notes
isaacs/minimatch (minimatch)
v10.2.3Compare Source
v10.2.2Compare Source
v10.2.1Compare Source
v10.2.0Compare Source
v10.1.3Compare Source
v10.1.2Compare Source
v10.1.1Compare Source
v10.1.0Compare Source
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.