Skip to content

fix(sdk): remove unused workflowId parameter from localizeChunk#2038

Open
AndreyHirsa wants to merge 1 commit intomainfrom
fix/sdk-remove-dead-workflowid
Open

fix(sdk): remove unused workflowId parameter from localizeChunk#2038
AndreyHirsa wants to merge 1 commit intomainfrom
fix/sdk-remove-dead-workflowid

Conversation

@AndreyHirsa
Copy link
Contributor

@AndreyHirsa AndreyHirsa commented Mar 7, 2026

Summary

Remove dead workflowId parameter from internal SDK method localizeChunk.

Changes

  • Removed unused workflowId parameter from private localizeChunk method
  • Removed workflowId generation via createId() in _localizeRaw
  • Cleaned up corresponding JSDoc

Testing

Business logic tests added:

  • All existing 24 SDK tests pass locally

Visuals

N/A — no UI changes.

Checklist

  • Changeset added (if version bump needed)
  • Tests cover business logic (not just happy path)
  • No breaking changes (or documented below)

Summary by CodeRabbit

  • Chores
    • Removed unused internal parameters from the chunk processing pipeline and updated related documentation for improved code maintainability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8dd8cf80-6ca8-4599-bc2e-2489d2dc92d8

📥 Commits

Reviewing files that changed from the base of the PR and between dbbb245 and a6bf8ae.

📒 Files selected for processing (2)
  • .changeset/little-nails-notice.md
  • packages/sdk/src/index.ts
💤 Files with no reviewable changes (1)
  • packages/sdk/src/index.ts

📝 Walkthrough

Walkthrough

The changeset documents a patch version for the SDK with removal of an unused workflowId parameter from the internal localizeChunk method. All call sites and method signatures are updated accordingly.

Changes

Cohort / File(s) Summary
Changeset Documentation
.changeset/little-nails-notice.md
New changeset file documenting patch version bump and workflowId parameter removal.
SDK Implementation
packages/sdk/src/index.ts
Removed workflowId parameter generation, method signature update to localizeChunk, and updated internal call sites to no longer pass workflowId argument.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • vrcprl

Poem

🐰 A parameter unused, now cast away,
Like whiskers trimmed, our code's less gray,
The chunks flow swift without that weight,
Cleaner paths make faster fate! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: removing the unused workflowId parameter from the localizeChunk method.
Description check ✅ Passed The description follows the template structure with Summary, Changes, Testing, Visuals, and Checklist sections completed; all required information is present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/sdk-remove-dead-workflowid

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant