Skip non-key entries in list_paginated#4456
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Mar 3, 2026
Merged
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
TheBlueMatt
reviewed
Mar 2, 2026
Use dir_entry_is_key in list_paginated_impl to skip .tmp files, directories, and other non-key entries, to be the same as list_impl. Claude added a test for this as well.
benthecarman
force-pushed
the
paginated-follow-ups2
branch
from
0b085d2 to
1545ad5
Compare
TheBlueMatt
approved these changes
Mar 3, 2026
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
easy enough, thanks. landing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4456 +/- ##
==========================================
+ Coverage 85.95% 85.96% +0.01%
==========================================
Files 159 159
Lines 104694 104714 +20
Branches 104694 104714 +20
==========================================
+ Hits 89987 90016 +29
+ Misses 12204 12194 -10
- Partials 2503 2504 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use dir_entry_is_key in list_paginated_impl to skip .tmp files, directories, and other non-key entries, to be the same as list_impl.
Claude added a test for this as well.
Closes #4455