support top level custom keywords starting with "x-"#279
Merged
Conversation
Reviewer's GuideThis pull request introduces support for custom top-level configuration keys prefixed with File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @kindermax - I've reviewed your changes - here's some feedback:
- Consider splitting the documentation refactoring (sidebar structure, config table of contents) into a separate PR from the
x-keyword and env aliasing feature.
Here's what I looked at during the review
- 🟡 General issues: 9 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
* "x-" prefixed top level keywords are now supported. This allows alias this data in env * env can now alias "x-" prefixed maps which will be merged with "env" * improve docs - sidebar now has better nesting * improve docs - add conditional "init" explanation * add bats and unit tests
6e2204d to
8501169
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add support for top-level custom keywords starting with "x-" and improve YAML aliasing for environment variables
New Features:
Enhancements:
Documentation:
Tests: