Pass-through AbstractOptimizerAttribute#335
Merged
andrewrosemberg merged 3 commits intojump-dev:masterfrom Feb 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 89.13% 89.14% +0.01%
==========================================
Files 16 16
Lines 1961 1963 +2
==========================================
+ Hits 1748 1750 +2
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
I'm trying to think if there is any attribute that could break diffopt if it got passed but I don't think so. LGTM after format and could be nice to add some tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to use
nonlinear_diff_modelthenset_optimizer_attribute:(Note the "The following options are ignored" message is a bug in MadNLP master that will be fixed before the next release, as you can see below it is in fact using cuDSS)