Add imageRegistry/imageNamespace to Helm chart image settings#782
Open
FelixPhipps wants to merge 1 commit intomasterfrom
Open
Add imageRegistry/imageNamespace to Helm chart image settings#782FelixPhipps wants to merge 1 commit intomasterfrom
FelixPhipps wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: felix.phipps <felix.phipps@cyberark.com>
FelixPhipps
force-pushed
the
update-helm-secure
branch
from
cd947e1 to
f5064b2
Compare
SgtCoDFish
reviewed
Mar 3, 2026
| ( .image.tag = "$(helm_image_tag)" )' \ | ||
| $1 --inplace | ||
| echo "no mutations defined for this chart" | ||
| endef |
Contributor
There was a problem hiding this comment.
suggestion: I think something like this might be missing for the disco-agent chart in
jetstack-secure/make/ark/00_mod.mk
Line 28 in b7cf60b
For me, the e2e tests are legitimately failing now that the disco backend issues are fixed!
FelixPhipps
force-pushed
the
update-helm-secure
branch
from
f5064b2 to
0678c6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds imageRegistry and imageNamespace values, aligning image configuration with cert-manager charts.
Implements https://github.com/cert-manager/cert-manager/blob/master/design/20260120.images-in-the-helm-chart.md (cert-manager/cert-manager#8425)