-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(item-sliding): add automatic full expand animation of items #31036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OS-pedrolourenco
wants to merge
32
commits into
next
Choose a base branch
from
ROU-12664
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+496
−3
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
6017570
First checkpoint
OS-pedrolourenco 994b969
Second checkpoint
OS-pedrolourenco a6f271f
Add automatic full expand animation to items
OS-pedrolourenco 63274c0
Tweaks
OS-pedrolourenco bd8568f
Fix disabled option bug + add tests
OS-pedrolourenco 87ddc89
Fix lint issues
OS-pedrolourenco e0736dc
Merge branch 'refs/heads/next' into ROU-12664
OS-pedrolourenco 258e9df
Skip flaky tests
OS-pedrolourenco 0e9abb2
Merge branch 'next' into ROU-12664
OS-pedrolourenco ed9bee5
fix(angular): forward generic type parameter on ModalOptions and Popo…
ShaneK 08388ee
test(spinner): add transform test back (#31017)
thetaPC 9aaecc9
v8.8.2
Ionitron 24861e5
chore(): update package lock files
Ionitron 9fc848a
fix(datetime): scroll failing for adjacent days on ios (#31033)
os-davidlourenco 60df9d6
chore(deps): update playwright (#30810)
renovate[bot] bad2ac7
fix(input-otp): prevent deletion and paste when disabled or readonly …
KanhaiyaPandey f76e46e
chore(): add updated snapshots
Ionitron 4cb32a1
chore(): add updated snapshots
Ionitron 51db026
chore: sync next with main (#31040)
brandyscarney 7762854
Merge branch 'next' into ROU-12664
brandyscarney 55eec20
CR
OS-pedrolourenco 004e33c
CR
OS-pedrolourenco f06c1ad
CR
OS-pedrolourenco cdbcdb7
CR
OS-pedrolourenco bfc4073
Merge branch 'next' into ROU-12664
OS-pedrolourenco c66de41
Revert mistaken button snapshots
OS-pedrolourenco 9f5e28a
CR
OS-pedrolourenco 754be74
Leverage tmr pattern
OS-pedrolourenco 5a64eac
CR + fix lint issue
OS-pedrolourenco b63ddfc
CR
OS-pedrolourenco 1130b7e
Indentation
OS-pedrolourenco 9a58724
CR
OS-pedrolourenco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
131 changes: 131 additions & 0 deletions
131
core/src/components/item-sliding/test/full-swipe/index.html
OS-pedrolourenco marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en" dir="ltr"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <title>Item Sliding - Full Swipe</title> | ||
| <meta | ||
| name="viewport" | ||
| content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no, viewport-fit=cover" | ||
| /> | ||
| <link href="../../../../../css/ionic.bundle.css" rel="stylesheet" /> | ||
| <link href="../../../../../scripts/testing/styles.css" rel="stylesheet" /> | ||
| <script src="../../../../../scripts/testing/scripts.js"></script> | ||
| <script nomodule src="../../../../../dist/ionic/ionic.js"></script> | ||
| <script type="module" src="../../../../../dist/ionic/ionic.esm.js"></script> | ||
| <style> | ||
| h2 { | ||
| font-size: 12px; | ||
| font-weight: normal; | ||
|
|
||
| color: #6f7378; | ||
|
|
||
| margin-top: 10px; | ||
| margin-left: 5px; | ||
| } | ||
| </style> | ||
| </head> | ||
|
|
||
| <body> | ||
| <ion-app> | ||
| <ion-header> | ||
| <ion-toolbar> | ||
| <ion-title>Item Sliding - Full Swipe</ion-title> | ||
| </ion-toolbar> | ||
| </ion-header> | ||
|
|
||
| <ion-content> | ||
| <div class="ion-padding-start" style="padding-top: 30px"> | ||
| <h2>Full Swipe - Expandable Options</h2> | ||
| </div> | ||
| <ion-list> | ||
| <!-- Expandable option on end side --> | ||
| <ion-item-sliding id="expandable-end"> | ||
| <ion-item> | ||
| <ion-label>Expandable End (Swipe Left)</ion-label> | ||
| </ion-item> | ||
| <ion-item-options side="end"> | ||
| <ion-item-option expandable="true" color="danger">Delete</ion-item-option> | ||
| </ion-item-options> | ||
| </ion-item-sliding> | ||
|
|
||
| <!-- Expandable on start side --> | ||
| <ion-item-sliding id="expandable-start"> | ||
| <ion-item> | ||
| <ion-label>Expandable Start (Swipe Right)</ion-label> | ||
| </ion-item> | ||
| <ion-item-options side="start"> | ||
| <ion-item-option expandable="true" color="success">Archive</ion-item-option> | ||
| </ion-item-options> | ||
| </ion-item-sliding> | ||
|
|
||
| <!-- Both sides with expandable --> | ||
| <ion-item-sliding id="expandable-both"> | ||
| <ion-item> | ||
| <ion-label>Expandable Both Sides</ion-label> | ||
| </ion-item> | ||
| <ion-item-options side="start"> | ||
| <ion-item-option expandable="true" color="success">Archive</ion-item-option> | ||
| </ion-item-options> | ||
| <ion-item-options side="end"> | ||
| <ion-item-option expandable="true" color="danger">Delete</ion-item-option> | ||
| </ion-item-options> | ||
| </ion-item-sliding> | ||
| </ion-list> | ||
|
|
||
| <div class="ion-padding-start" style="padding-top: 30px"> | ||
| <h2>Non-Expandable Options (No Full Swipe)</h2> | ||
| </div> | ||
| <ion-list> | ||
| <!-- Non-expandable option --> | ||
| <ion-item-sliding id="non-expandable"> | ||
| <ion-item> | ||
| <ion-label>Non-Expandable (Should Show Options)</ion-label> | ||
| </ion-item> | ||
| <ion-item-options side="end"> | ||
| <ion-item-option color="primary">Edit</ion-item-option> | ||
| </ion-item-options> | ||
| </ion-item-sliding> | ||
|
|
||
| <!-- Multiple non-expandable options --> | ||
| <ion-item-sliding id="non-expandable-multiple"> | ||
| <ion-item> | ||
| <ion-label>Multiple Non-Expandable Options</ion-label> | ||
| </ion-item> | ||
| <ion-item-options side="end"> | ||
| <ion-item-option color="primary">Edit</ion-item-option> | ||
| <ion-item-option color="secondary">Share</ion-item-option> | ||
| <ion-item-option color="danger">Delete</ion-item-option> | ||
| </ion-item-options> | ||
| </ion-item-sliding> | ||
| </ion-list> | ||
|
|
||
| <div class="ion-padding-start" style="padding-top: 30px"> | ||
| <h2>Mixed Scenarios</h2> | ||
| </div> | ||
| <ion-list> | ||
| <!-- Expandable with multiple options --> | ||
| <ion-item-sliding id="expandable-with-others"> | ||
| <ion-item> | ||
| <ion-label>Expandable + Other Options</ion-label> | ||
| </ion-item> | ||
| <ion-item-options side="end"> | ||
| <ion-item-option color="primary">Edit</ion-item-option> | ||
| <ion-item-option expandable="true" color="danger">Delete</ion-item-option> | ||
| </ion-item-options> | ||
| </ion-item-sliding> | ||
| </ion-list> | ||
| </ion-content> | ||
| </ion-app> | ||
| <script> | ||
| // Log swipe events for debugging | ||
| document.querySelectorAll('ion-item-sliding').forEach((item) => { | ||
| const id = item.getAttribute('id'); | ||
| item.querySelectorAll('ion-item-options').forEach((options) => { | ||
| options.addEventListener('ionSwipe', () => { | ||
| console.log(`[${id}] ionSwipe fired on ${options.getAttribute('side')} side`); | ||
| }); | ||
| }); | ||
| }); | ||
| </script> | ||
| </body> | ||
| </html> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.