refactor(rfcs): centralize RFC sidebar and source metadata#205
Open
JoblersTune wants to merge 1 commit intomainfrom
Open
refactor(rfcs): centralize RFC sidebar and source metadata#205JoblersTune wants to merge 1 commit intomainfrom
JoblersTune wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for developers-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Fixes #123)bun run formatto ensure code is properly formattedbun run lintpasses without errorsSummary
This PR centralizes published RFC metadata in src/data/rfcs.ts so it can act as the single source of truth for RFC routes, titles, and raw source URLs.
The Starlight sidebar in astro.config.mjs now derives its RFC entries from that shared data instead of duplicating each label and link inline. The RFC MDX pages under src/content/docs/rfcs were also updated to resolve their Rfc component source prop via getRfcById(...) rather than hardcoded GitHub raw URLs. This reduces repetition and keeps sidebar navigation and RFC page sources aligned from one place.
You can test by clicking through the spec here https://deploy-preview-205--developers-preview.netlify.app/developers/rfcs/interledger-protocol/