fix: report frequency table for CWF and frequency benchmark for CWF#676
Open
harp-intel wants to merge 5 commits intomainfrom
Open
fix: report frequency table for CWF and frequency benchmark for CWF#676harp-intel wants to merge 5 commits intomainfrom
harp-intel wants to merge 5 commits intomainfrom
Conversation
…ute dies Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates PerfSpect’s x86 frequency benchmark script to better handle multi-die Intel CPUs (GNR/CWF) by interleaving core IDs across dies, and switches compute-die counting from lspci-based heuristics to pcm-tpmi output parsing.
Changes:
- Extend special interleaving logic to apply to both GNR (model 173) and CWF (model 221).
- Replace compute-die detection from
lspcidevice counting to parsingpcm-tpmioutput, and recomputedies_per_socketaccordingly. - Update the frequency benchmark script dependency list to include
pcm-tpmiinstead oflspci.
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CWF requires core interleaving for frequency benchmarking.
CWF frequency table from tpmi.
This pull request updates the logic for handling CPU architectures with multiple dies, especially focusing on CWF and GNR architectures. The changes improve how core counts and die counts are determined and used, and update the scripts to more accurately detect and process multi-die CPUs.
Key changes include:
Frequency bucket calculation improvements:
GetSpecFrequencyBucketsto use explicitnumDiesandcoreMultipliervariables, allowing more accurate handling of architectures with multiple dies and varying core multipliers. This replaces the previousarchMultiplierlogic and ensures correct bucket ranges for CWF and GNR architectures.numDiesinstead of the old multiplier, ensuring correct column headers and row data for multi-die architectures. [1] [2]Script and architecture detection enhancements:
pcm-tpmioutput, providing a more robust and accurate way to determine the number of compute dies per socket. Added error handling for missing die or socket counts.pcm-tpmiinstead oflspcifor accurate die detection.