Skip to content

fix(mpeg-dash): quote GROUP-ID in EXT-X-MEDIA for HLS #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajankristof merged 2 commits into from
Jul 17, 2025
Merged

fix(mpeg-dash): quote GROUP-ID in EXT-X-MEDIA for HLS #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07c1df9
fix(mpeg-dash): quote GROUP-ID in EXT-X-MEDIA for HLS
bajankristof Jul 17, 2025
3f6e15d
chore: update version to 8.1.0-beta.1 and document changes
bajankristof Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
== 8.1.0-beta.1 2025-07-17

Fixes:
* Correctly implement HLS specification for EXT-X-MEDIA and GROUP-ID.

== 8.1.0-beta 2025-07-15

Improvements:
Expand Down
2 changes: 1 addition & 1 deletion lib/ffmpeg/dash/adaptation_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def to_m3u8mt(group_id: content_type, default: true, autoselect: true)
m3u8t(
'EXT-X-MEDIA',
'TYPE' => content_type.upcase,
'GROUP-ID' => group_id,
'GROUP-ID' => quote(group_id),
'NAME' => quote(lang || 'und'),
'LANGUAGE' => quote(lang || 'und'),
'DEFAULT' => default ? 'YES' : 'NO',
Expand Down
2 changes: 1 addition & 1 deletion lib/ffmpeg/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module FFMPEG
VERSION = '8.1.0-beta'
VERSION = '8.1.0-beta.1'
end
6 changes: 3 additions & 3 deletions spec/ffmpeg/dash/adaptation_set_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
it 'returns an EXT-X-MEDIA tag' do
is_expected.to eq(
'#EXT-X-MEDIA:TYPE=AUDIO,' \
'GROUP-ID=audio,NAME="und",LANGUAGE="und",DEFAULT=YES,AUTOSELECT=YES,URI="stream2.m3u8"'
'GROUP-ID="audio",NAME="und",LANGUAGE="und",DEFAULT=YES,AUTOSELECT=YES,URI="stream2.m3u8"'
)
end
end
Expand All @@ -147,7 +147,7 @@
it 'returns an EXT-X-MEDIA tag' do
is_expected.to eq(
'#EXT-X-MEDIA:TYPE=VIDEO,' \
'GROUP-ID=video,NAME="und",LANGUAGE="und",DEFAULT=NO,AUTOSELECT=NO,URI="stream0.m3u8"'
'GROUP-ID="video",NAME="und",LANGUAGE="und",DEFAULT=NO,AUTOSELECT=NO,URI="stream0.m3u8"'
)
end
end
Expand Down Expand Up @@ -177,7 +177,7 @@
it 'uses the specified language' do
is_expected.to eq(
'#EXT-X-MEDIA:TYPE=AUDIO,' \
'GROUP-ID=audio,NAME="en",LANGUAGE="en",DEFAULT=YES,AUTOSELECT=YES,URI="stream0.m3u8"'
'GROUP-ID="audio",NAME="en",LANGUAGE="en",DEFAULT=YES,AUTOSELECT=YES,URI="stream0.m3u8"'
)
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/ffmpeg/dash/manifest_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
is_expected.to eq(<<~M3U8.strip)
#EXTM3U
#EXT-X-VERSION:6
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID=audio,NAME="und",LANGUAGE="und",DEFAULT=YES,AUTOSELECT=YES,URI="stream2.m3u8"
#EXT-X-MEDIA:TYPE=AUDIO,GROUP-ID="audio",NAME="und",LANGUAGE="und",DEFAULT=YES,AUTOSELECT=YES,URI="stream2.m3u8"
#EXT-X-STREAM-INF:BANDWIDTH=2500000,CODECS="avc1.640028",RESOLUTION=1920x1080,AUDIO="audio"
stream0.m3u8
#EXT-X-STREAM-INF:BANDWIDTH=1250000,CODECS="avc1.640028",RESOLUTION=1280x720,AUDIO="audio"
Expand Down