Add seek() method to ZstdCompressionReader#287
Open
chromy wants to merge 1 commit intoindygreg:mainfrom
Open
Conversation
Even though ZstdCompressionReader doesn't support seek()ing we should probably follow the interface of: https://docs.python.org/3/library/io.html#io.IOBase.seek and define a seek method which raises OSError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though ZstdCompressionReader doesn't support seek()ing we should
probably follow the interface of:
https://docs.python.org/3/library/io.html#io.IOBase.seek
and define a seek method which raises OSError.
Found this in the course of investigating urllib3/urllib3#3779.
I don't know much Rust / cffi but I tried to do what looked correct from the surrounding context!