Multifunction add battery voltage warnings#11308
Multifunction add battery voltage warnings#11308breadoven wants to merge 7 commits intoiNavFlight:maintenance-9.xfrom
Conversation
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
|
Thanks, Breadoven. |
Looking at 7.0 to 7.1 there were new settings added, e.g. #9502, which I'd have thought required a PG version bump, although #9502 omitted it ... I assume by mistake. Having said that I've missed the PG version bump for this PR so it needs adding before merging. |
|
I got curious and did a little audit of 5.0 → 5.1 → 6.0 → 6.1 → 7.0 → 7.1 → 8.0 → 9.0 PG struct changes are normally in major versions. But of 60 struct changes I found, 15 missed the version bump. I added a release-time check for that.
If nobody disagrees, I think I'm going to schedule PG changes (and requiring a full erase) for major versions. Unless the setting isn't really needed. It's possible that we have too dang many settings already, making it hard for users to know which settings they actually need to pay attention to. 😊 |
|
The setting could be pushed to 10.0 with just the voltage warning added for 9.1. In that case it's probably best to just have the warnings display constantly which shouldn't be a problem now the blinking has been removed which is much less distracting. |
|
This has now been changed to remove the setting entirely. The warnings now display constantly without blinking with the exception of new warnings which are displayed individually for 10s with blinking to highlight the fact it's a new warning. After the 10s all current warnings are displayed on a 1s cycle without blinking. |
|
I would like to see the list of warnings and how (in what exact form/text) they appear. Is it available somewhere? |
Battery voltage: Battery capacity: Sensor warnings: Sanity warnings: |
|
thank you |
User description
Adds battery voltage warning to Multifunction OSD element.
Also changes the warning display logic. The warnings now display constantly without blinking with the exception of new warnings which are displayed individually for 10s with blinking to highlight the fact it's a new warning. After the 10s all current warnings are displayed on a 1s cycle without blinking. The multifunction option to redisplay warnings has been removed as it's no longer needed.
Minor bug fixed causing inconsistency checking battery voltage status when battery capacity being used for battery status.
Should close #11259.
PR Type
Enhancement
Description
Adds battery voltage warning to multifunction OSD element
Introduces configurable warning cycle time setting (0-60s)
Separates voltage and capacity battery warnings for clarity
Updates warning display logic to use configurable cycle time
Diagram Walkthrough
File Walkthrough
osd.c
Implement voltage warning and configurable cycle timesrc/main/io/osd.c
multifunction_warning_cycle_timefield initialization in OSDconfig reset template
of hardcoded 30s
warnings
warning
osd.h
Add warning cycle time configuration fieldsrc/main/io/osd.h
multifunction_warning_cycle_timefield toosdConfig_sstructuresettings.yaml
Register warning cycle time in settings schemasrc/main/fc/settings.yaml
multifunction_warning_cycle_timesetting definition to OSDsettings group
Settings.md
Document multifunction warning cycle time settingdocs/Settings.md
multifunction_warning_cycle_timesetting