Merged
Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions runs-on label selection for the repo’s self-hosted 1ES runner pools by adding a JobId=... label to help disambiguate/route jobs (per the approach referenced in hyperlight-dev/hyperlight#1353).
Changes:
- Add a
JobId=...label to theruns-onselector in the Rust dependency workflow (dep_rust.yml) for matrix jobs. - Add a
JobId=...label to theruns-onselector in the Benchmarks workflow for matrix jobs. - Add a
JobId=...label to the cargo publish workflow runner selector.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/dep_rust.yml | Appends a JobId=build-... label to the existing 1ES pool runner label selection for the build matrix. |
| .github/workflows/dep_cargo_publish.yml | Adds a JobId=publish-hyperlight-wasm-... label to the 1ES pool runner label list for the publish job. |
| .github/workflows/Benchmarks.yml | Appends a JobId=benchmark-... label to the existing 1ES pool runner label selection for the benchmark matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsturtevant
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same as hyperlight-dev/hyperlight#1353