Trimming alternatives for anyOf/oneOf based on type#170
Merged
jdesrosiers merged 5 commits intohyperjump-io:mainfrom Feb 25, 2026
Merged
Trimming alternatives for anyOf/oneOf based on type#170jdesrosiers merged 5 commits intohyperjump-io:mainfrom
jdesrosiers merged 5 commits intohyperjump-io:mainfrom
Conversation
Add a newline at the end of the JSON file
Add missing newline at the end of anyOf.json
jdesrosiers
requested changes
Feb 19, 2026
Contributor
Author
|
Hey @jdesrosiers , I've made some changes please have a look whenever you're free and tell me if I'm proceeding in the right direction. |
jdesrosiers
requested changes
Feb 24, 2026
Collaborator
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
Looks good. The type check ended up being simpler that I expected which is great! I left a couple notes for some things that can be cleaned up a little.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the error reporting for
anyOfandoneOfkeywords by filtering out irrelevant schema alternatives based on the instance's type. This results in significantly cleaner error messages.Fixes : #165
Changes
The error handlers now check the type keyword of each alternative. If an alternative expects a type different from the instance it is excluded from the error report.
If filtering results in
only onealternative, then anyOf / oneOf wrapper error is removed entirely.If no alternatives match the instance type (or if types aren't specified), the original behavior is preserved all alternatives are reported.