chore: refactor knip CI to fail on issues and simplify comment format

[brandon-pereira]

Summary

Refactors the Knip CI workflow to be simpler and stricter:

• Removed main branch comparison — no longer checks out main or runs knip on it. The workflow only analyzes the PR branch.
• Comment only on failure — if knip finds 0 issues, no comment is posted. If a stale comment exists from a previous push, it's deleted.
• Simplified comment format — replaced the comparison table with a flat per-category breakdown listing each issue directly.
• Job fails on issues — core.setFailed() is called when knip detects issues, so the check goes red.
• Removed excluded categories — enumMembers and duplicates are excluded in knip.json, so they were removed from the workflow.
• Added test fixtures — an unused export and unused file to verify the workflow triggers correctly on this PR.

How to test locally or on Vercel

1. Check the Knip CI action on this PR — it should fail and post a comment listing the test fixtures.
2. Verify the comment shows Unused files and Unused exports sections with the test items.
3. After confirming, the test fixtures (KNIP_TEST_UNUSED_EXPORT in defaults.ts and knipTestUnusedFile.ts) should be removed before merge.

References

• Related PRs: chore: resolve remaining knip issues #1991 (initial knip cleanup)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 01458db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Mar 27, 2026 10:59pm

[github-actions]

E2E Test Results

✅ All tests passed • 103 passed • 3 skipped • 980s

Status	Count
✅ Passed	103
❌ Failed	0
⚠️ Flaky	1
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →

[github-actions]

PR Review

• ⚠️ Silent failure when knip errors → parseResults catch block returns { total: 0 }, so if knip crashes or produces invalid JSON, the job passes with "No knip issues found." Combined with 2>/dev/null || true suppressing all stderr/exit codes, a broken knip config would silently pass CI. Consider checking if the output file exists and has content before treating zero issues as success.

• ✅ The files category parsing change (reading from data.issues instead of top-level data.files) aligns with commit f25e0afe which explicitly fixed this — no concern there.

• ✅ Test fixtures are net-zero in the PR diff (added then removed before merge) — nothing leaks into main.

• ✅ Overall refactor is clean: single run, fail-on-issues behavior, stale comment cleanup all look correct.