Skip to content

fix: Properly enable line wrap behavior in JSON viewer by default#1998

Open
MikeShi42 wants to merge 1 commit intomainfrom
mikeshi/fix-line-wrap
Open

fix: Properly enable line wrap behavior in JSON viewer by default#1998
MikeShi42 wants to merge 1 commit intomainfrom
mikeshi/fix-line-wrap

Conversation

@MikeShi42
Copy link
Copy Markdown
Contributor

@MikeShi42 MikeShi42 commented Mar 27, 2026

Resolves HDX-3845

New Old
image image

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026

🦋 Changeset detected

Latest commit: 7a9f0a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Mar 27, 2026 7:18am

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

Knip - Unused Code Analysis

⚪ No changes detected (182 issues on both main and PR)

What is this?

Knip finds unused files, dependencies, and exports in your codebase.
This comment compares the PR branch against main to detect regressions.

Run yarn knip locally to see full details.

@github-actions
Copy link
Copy Markdown
Contributor

PR Review

✅ No critical issues found.

The migration logic is correct and well-tested. A few minor observations:

  • JSON.stringify({ whiteSpace: undefined }) drops the key, meaning migrated users with old lineWrap: true will have no whiteSpace in storage — this is intentional and correctly handled by effectiveWhiteSpace = jsonOptions.whiteSpace ?? 'pre-wrap'.
  • All HyperJson callers have been updated; no lingering lineWrap prop usage remains.
  • Unit tests cover migration edge cases; E2E tests cover toggle, persistence, and migration paths.
  • The @internal export of migrateViewerOptions is a reasonable pattern for testability.

@github-actions
Copy link
Copy Markdown
Contributor

E2E Test Results

All tests passed • 107 passed • 3 skipped • 1090s

Status Count
✅ Passed 107
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant