Fix Kafka integration test SASL configuration#796
Merged
Conversation
The Kafka integration test was always failing because the test configured SASL PLAIN credentials but the Kafka containers ran with PLAINTEXT listeners (no SASL), causing "Illegal SASL State" errors. - Add SASL PLAIN config to compose test-kafka container - Add kafka_jaas.conf mounted into the container - Update testcontainer with matching SASL config - Update test consumer and topic helper to use SASL dialer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
alexbouchardd
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestKafkaPublishIntegration) was always failing because test containers ran without SASL while the test configured SASL PLAIN credentialsadmin/admin-secret)kafka_jaas.confmounted into the compose containerTest plan
make testpasses with zero failuresTestKafkaPublishIntegrationpasses against compose containerTestKafkaDestination_Validatepasses🤖 Generated with Claude Code