Conversation
…ent step - Assess: add review_feedback to output when trigger is PR review or comment on PR - Action: pass review_feedback as REVIEW_FEEDBACK to implement step - Implement: include 'Review feedback to address' in prompt when REVIEW_FEEDBACK set - run-local-assess: pass REVIEW_FEEDBACK when running implement - Always log Claude assess response to stderr; ASSESS_DEBUG=1 logs full prompt - Add unit tests for review_feedback (pull_request_review, issue_comment on PR) - Add DIAGNOSIS-PR-261.md documenting why bot replied 'Verification passed' instead of adding tests Fixes the case where a reviewer asks for tests (or other follow-up) on a PR and the bot only saw the original issue, so it replied with no code changes. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a reviewer comments on an auto-implement PR (e.g. "Could we add some unit and acceptance test coverage?"), the bot was replying "Verification passed" with no code changes because the implement step never received the review/comment text — it only saw the original issue.
Changes
pull_request_review,pull_request_review_comment, orissue_commenton a PR, addreview_feedbackto the JSON output (the exact review/comment body).review_feedbackfrom assess to the implement step asREVIEW_FEEDBACK.REVIEW_FEEDBACKis set, add a clear "Review feedback to address (you must implement this)" section to the Claude Code CLI prompt so it actually implements the reviewer's ask (e.g. add tests).REVIEW_FEEDBACKwhen running implement locally (fromresult.review_feedbackorCOMMENT_BODY/REVIEW_BODY).ASSESS_DEBUG=1additionally logs the full prompt.review_feedbackwhen event ispull_request_revieworissue_commenton a PR.DIAGNOSIS-PR-261.mddocumenting the root cause (PR Add --local flag to login and ci commands #261 follow-up).Testing
cd .github/actions/issue-auto-implement/assess && npm test— 18 tests pass.Made with Cursor