fix: correct version comparison to handle semver and pre-release tags#250
Merged
fix: correct version comparison to handle semver and pre-release tags#250
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI's "newer version available" prompt was using a plain string comparison after stripping the
vprefix. This caused two bugs:1.9.xwas considered newer than1.10.xbecause"9" > "1"lexicographically.1.9.1would be flagged as needing an upgrade to1.10.0-beta.4even though that is a pre-release.How it was solved
Replaced the single-line string comparison in
needsToUpgradewith proper semantic version logic:.and each segment is compared as an integer, so1.10.0 > 1.9.1correctly.beta.9vsbeta.10) are compared segment-by-segment with numeric segments compared as integers.New unit tests cover all the edge cases including the exact scenario from the issue (
1.9.1current,1.10.0-beta.4latest → no prompt).