Skip to content

Add README.chromium#4616

Merged
kainino0x merged 1 commit intogpuweb:mainfrom
kainino0x:readme.chromium
Mar 20, 2026
Merged

Add README.chromium#4616
kainino0x merged 1 commit intogpuweb:mainfrom
kainino0x:readme.chromium

Conversation

@kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Mar 19, 2026

Metadata file for Chromium. Normally this would be stored in Chromium, but for historical reasons it's much easier to just put it here. Apologies :)
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/adding_to_third_party.md#readme_chromium

Hopefully this works.

Issue: https://crbug.com/493761246


Requirements for PR author:

  • [n/a] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [n/a] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [n/a] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [n/a] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • [n/a] Tests are properly located.
  • [n/a] Test descriptions are accurate and complete.
  • [n/a] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • [n/a] Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x marked this pull request as ready for review March 19, 2026 20:13
@github-actions
Copy link

Results for build job (at 3c7e67a):

 Test case/subcase counts did not change.

@kainino0x kainino0x requested a review from Kangz March 19, 2026 20:16
@kainino0x kainino0x enabled auto-merge (squash) March 19, 2026 20:17
Copy link
Collaborator

@Kangz Kangz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please see the comment on the relevant issue. What would moving into an src/ subdir entail?

@kainino0x kainino0x merged commit 857b158 into gpuweb:main Mar 20, 2026
1 check passed
@kainino0x kainino0x deleted the readme.chromium branch March 20, 2026 18:02
@kainino0x
Copy link
Collaborator Author

whoops, shouldn't have autosubmitted

kainino0x added a commit to kainino0x/cts that referenced this pull request Mar 20, 2026
kainino0x added a commit that referenced this pull request Mar 20, 2026
This reverts commit 857b158.

I made an error in the format of the file. Also might not end up doing this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants