feat(visionai): generate library#16008
Merged
scotthart merged 5 commits intogoogleapis:mainfrom Feb 25, 2026
Merged
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on generating and integrating the C++ client library for the Vision AI API. It encompasses updates to various build configurations, dependency management, and documentation to fully support the new service within the existing framework. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the generated C++ client library for the Vision AI API. The changes are mostly additions of new files for the library, its documentation, and quickstart examples. The PR also includes updates to the project's build files (Bazel, CMake), dependency versions, and CI configurations to incorporate the new library.
My review has identified a couple of issues:
- The copyright year for the new library is set to a future year (2026) in the generator configuration, which affects all generated files.
- A CI script contains redundant code that should be cleaned up for better maintainability.
Comment on lines
+4042
to
+4082
| service { | ||
| service_proto_path: "google/cloud/visionai/v1/health_service.proto" | ||
| product_path: "google/cloud/visionai/v1" | ||
| initial_copyright_year: "2026" | ||
| retryable_status_codes: ["kUnavailable"] | ||
| } | ||
|
|
||
| service { | ||
| service_proto_path: "google/cloud/visionai/v1/lva_service.proto" | ||
| product_path: "google/cloud/visionai/v1" | ||
| initial_copyright_year: "2026" | ||
| retryable_status_codes: ["kUnavailable"] | ||
| } | ||
|
|
||
| service { | ||
| service_proto_path: "google/cloud/visionai/v1/platform.proto" | ||
| product_path: "google/cloud/visionai/v1" | ||
| initial_copyright_year: "2026" | ||
| retryable_status_codes: ["kUnavailable"] | ||
| } | ||
|
|
||
| service { | ||
| service_proto_path: "google/cloud/visionai/v1/streaming_service.proto" | ||
| product_path: "google/cloud/visionai/v1" | ||
| initial_copyright_year: "2026" | ||
| retryable_status_codes: ["kUnavailable"] | ||
| } | ||
|
|
||
| service { | ||
| service_proto_path: "google/cloud/visionai/v1/streams_service.proto" | ||
| product_path: "google/cloud/visionai/v1" | ||
| initial_copyright_year: "2026" | ||
| retryable_status_codes: ["kUnavailable"] | ||
| } | ||
|
|
||
| service { | ||
| service_proto_path: "google/cloud/visionai/v1/warehouse.proto" | ||
| product_path: "google/cloud/visionai/v1" | ||
| initial_copyright_year: "2026" | ||
| retryable_status_codes: ["kUnavailable"] | ||
| } |
There was a problem hiding this comment.
The initial_copyright_year for all new visionai services is set to "2026", which is a future year. This value is propagated to the copyright headers of all newly generated files. This should be updated to the current year for all new service definitions.
Comment on lines
32
to
33
| protobuf_proto_path="${bazel_output_base}/external/protobuf+/src" | ||
| googleapis_proto_path="${bazel_output_base}/external/googleapis+" |
There was a problem hiding this comment.
Since these lines now define protobuf_proto_path and googleapis_proto_path, the read commands on lines 29-30 are redundant and can be removed to improve script clarity and avoid executing unnecessary find commands.
scotthart
force-pushed
the
feat-visionai-generate-library-2
branch
from
5b65c88 to
2beda2f
Compare
scotthart
force-pushed
the
feat-visionai-generate-library-2
branch
from
2beda2f to
fd7b5d1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16008 +/- ##
=======================================
Coverage 92.63% 92.64%
=======================================
Files 2333 2333
Lines 214631 214631
=======================================
+ Hits 198827 198846 +19
+ Misses 15804 15785 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jinseopkim0
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is