chore(deps): update dependency curl to v8.11.0.bcr.5#16007
chore(deps): update dependency curl to v8.11.0.bcr.5#16007renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
/gcbrun |
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the curl dependency from 8.8.0.bcr.3 to 8.11.0.bcr.5. This is an automated dependency update. I have raised a concern that this change may be incomplete. The project uses a highly customized build file for curl (bazel/curl.BUILD) which contains hardcoded source file lists and configuration flags. Such a file is often tightly coupled with the library version, and updating curl without updating this build file carries a high risk of breaking the build or introducing subtle bugs.
| bazel_dep(name = "boringssl", version = "0.20251124.0") | ||
| bazel_dep(name = "nlohmann_json", version = "3.12.0.bcr.1") | ||
| bazel_dep(name = "curl", version = "8.8.0.bcr.3") | ||
| bazel_dep(name = "curl", version = "8.11.0.bcr.5") |
There was a problem hiding this comment.
This version update is likely to be incompatible with the custom bazel/curl.BUILD file. That file contains hardcoded source file lists and preprocessor definitions (in a write_file rule generating curl_config.h) that are specific to a particular curl version. It is highly probable that updating from 8.8.0 to 8.11.0 requires changes to bazel/curl.BUILD to reflect changes in the curl source code and build configuration. Without these corresponding changes, this PR will likely break the build.
This PR contains the following updates:
8.8.0.bcr.3→8.11.0.bcr.5Configuration
📅 Schedule: Branch creation - Monday through Friday ( * * * * 1-5 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
This change is