feat: support --start-date and --end-date#61
Conversation
|
Hey @Pranavchiku, thanks for looking into this. I've had a quick scan through and think this might need a little more thought through (happy to carry on bouncing ideas through this PR) before we start talking about deeper implementation details. A few quick concerns that pop up:
There's a fair amount of additional change that would be needed based upon the above questions, so I think it's worth us (collectively as a community) pausing and considering these first 😄 |
|
I agree, we need to spend more time before making a final decision over the PR :) Will be happy to be part of any discussions you are wiling to. Edit: I marked PR as draft as it needs discussion. |
jimmydagenui
left a comment
There was a problem hiding this comment.
$SOURCE_REPOSITORY = <SOURCE_REPOSITORY_NAME>
$NUGET_V2_SOURCE_REPOSITORY_FEED_URL = <NUGET_V2_SOURCE_REPOSITORY_FEED_URL>
$DESTINATION_DIR = <PATH_TO_DESTINSTION_FOLDER>
Register-PackageSource -Name $SOURCE_REPOSITORY -Location $NUGET_V2_SOURCE_REPOSITORY_FEED_URL -Trusted -Credential $credential -ProviderName NuGet
Find-Package -AllVersions -Source $SOURCE_REPOSITORY -ProviderName NuGet -Credential $credential | ForEach-Object {
Save-Package -Name $.Name -RequiredVersion $.Version -Path $DESTINATION_DIR -Source $SOURCE_REPOSITORY -Credential $credential -ProviderName NuGet
}
|
|
||
| if !artOnly { | ||
| // Generate filename | ||
| outputPath := generateOutputFilename(targetUser, startYear, endYear) |
There was a problem hiding this comment.
$SOURCE_REPOSITORY = <SOURCE_REPOSITORY_NAME>
$NUGET_V2_SOURCE_REPOSITORY_FEED_URL = <NUGET_V2_SOURCE_REPOSITORY_FEED_URL>
$DESTINATION_DIR = <PATH_TO_DESTINSTION_FOLDER>
Register-PackageSource -Name $SOURCE_REPOSITORY -Location $NUGET_V2_SOURCE_REPOSITORY_FEED_URL -Trusted -Credential $credential -ProviderName NuGet
Find-Package -AllVersions -Source $SOURCE_REPOSITORY -ProviderName NuGet -Credential $credential | ForEach-Object {
Save-Package -Name $.Name -RequiredVersion $.Version -Path $DESTINATION_DIR -Source $SOURCE_REPOSITORY -Credential $credential -ProviderName NuGet
}

Potential fix for #33
With this now, we can do
% ./gh-skyline --user pranavchiku --year 2024 --debug --start-date 01-01-2024 --end-date 01-03-2024And it generates
pranavchiku-01-01-2024-01-03-2024-github-skyline