Fix Go version ordering in GetNpmBinPathSetup by Mossaka · Pull Request #14237 · github/gh-aw

Mossaka · 2026-02-06T22:27:42Z

Summary

Fix make build failure in smoke-codex caused by Go 1.23.12 shadowing Go 1.25.0 in PATH
Re-prepend $GOROOT/bin after the find command in GetNpmBinPathSetup() to ensure the version set by actions/setup-go takes precedence
Use || true to prevent && chain short-circuit when GOROOT is not set

Root Cause

GetNpmBinPathSetup() uses find /opt/hostedtoolcache -maxdepth 4 -type d -name bin to locate all bin directories. find returns results alphabetically, so go/1.23.12/x64/bin comes before go/1.25.0/x64/bin. This prepends the older Go version first in PATH, shadowing the correct version installed by actions/setup-go.

The copilot engine doesn't use GetNpmBinPathSetup() (it invokes copilot directly), which is why smoke-copilot doesn't have this issue.

Fix

After the find command prepends all hostedtoolcache bin directories, conditionally re-prepend $GOROOT/bin:

export PATH="$(find ... | tr '\n' ':')$PATH"; [ -n "$GOROOT" ] && export PATH="$GOROOT/bin:$PATH" || true

AWF's entrypoint.sh exports GOROOT before the user command runs, so the inner bash (codex/claude wrapper) inherits the correct value.

Test plan

TestGetNpmBinPathSetup — validates GOROOT re-prepend is present
TestGetNpmBinPathSetup_GorootOrdering — simulates two Go versions, verifies 1.25 wins
TestGetNpmBinPathSetup_NoGorootDoesNotBreakChain — verifies command chain continues when GOROOT is empty
All 147 workflows recompiled successfully
CI: smoke-codex make build succeeds with Go 1.25

🤖 Generated with Claude Code

Changeset

Type: patch
Description: Ensure the npm PATH helper re-prepends $GOROOT/bin after enumerating hostedtoolcache bins so Go versions set by actions/setup-go stay first and add regression coverage for the ordering and the empty-GOROOT command chain.

Generated by Changeset Generator

The find command in GetNpmBinPathSetup returns hostedtoolcache bin directories alphabetically, causing go/1.23.12 to shadow go/1.25.0 when both exist. This breaks `make build` in smoke-codex because go.mod requires >= 1.25.0 but the older version is found first. After the find prepends all bin dirs, re-prepend $GOROOT/bin so the version set by actions/setup-go takes precedence. Use `|| true` to ensure the command chain continues when GOROOT is not set. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Fixes PATH ordering for Go in GetNpmBinPathSetup() so the Go version selected by actions/setup-go (via $GOROOT) takes precedence over alphabetically earlier toolcache entries, addressing make build failures in smoke-codex.

Changes:

Update GetNpmBinPathSetup() to re-prepend $GOROOT/bin after the hostedtoolcache find PATH population and add || true to avoid && chain short-circuiting when GOROOT is unset.
Add unit + Linux shell-based tests covering ordering and chaining behavior.
Regenerate multiple workflow .lock.yml files to embed the updated PATH setup snippet.

Reviewed changes

Copilot reviewed 48 out of 48 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/workflow/engine_helpers.go	Adjust `GetNpmBinPathSetup()` PATH logic to ensure `$GOROOT/bin` wins over alphabetically ordered toolcache bins.
pkg/workflow/engine_helpers_test.go	Add tests for `GetNpmBinPathSetup()` string contents, Go precedence behavior, and `&&`-chain resilience when `GOROOT` is unset.
.github/workflows/unbloat-docs.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/typist.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/test-create-pr-error-handling.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/step-name-alignment.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/static-analysis-report.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/smoke-project.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/smoke-codex.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/smoke-claude.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/sergo.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/semantic-function-refactor.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/scout.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/schema-consistency-checker.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/safe-output-health.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/prompt-clustering-analysis.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/lockfile-stats.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/issue-arborist.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/instructions-janitor.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/go-pattern-detector.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/go-logger.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/go-fan.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/github-mcp-tools-report.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/github-mcp-structural-analysis.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/example-workflow-analyzer.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/duplicate-code-detector.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/developer-docs-consolidator.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/deep-report.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/daily-team-evolution-insights.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/daily-safe-output-optimizer.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/daily-performance-summary.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/daily-observability-report.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/daily-multi-device-docs-tester.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/daily-issues-report.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/daily-fact.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/daily-doc-updater.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/daily-code-metrics.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/daily-choice-test.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/copilot-session-insights.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/copilot-agent-analysis.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/commit-changes-analyzer.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/codex-github-remote-mcp-test.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/cloclo.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/cli-version-checker.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/claude-code-user-docs-review.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/changeset.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/blog-auditor.lock.yml	Regenerated lockfile to include updated PATH setup snippet.
.github/workflows/audit-workflows.lock.yml	Regenerated lockfile to include updated PATH setup snippet.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-06T22:32:41Z

pkg/workflow/engine_helpers_test.go

+	os.MkdirAll(goOld, 0o755)
+	os.MkdirAll(goNew, 0o755)
+
+	// Write fake go scripts: old reports 1.23, new reports 1.25
+	os.WriteFile(filepath.Join(goOld, "go"), []byte("#!/bin/bash\necho 'go version go1.23.12 linux/amd64'\n"), 0o755)
+	os.WriteFile(filepath.Join(goNew, "go"), []byte("#!/bin/bash\necho 'go version go1.25.0 linux/amd64'\n"), 0o755)


The test ignores errors from os.MkdirAll/os.WriteFile. If creating dirs/files fails, the test may still proceed and accidentally invoke the system go, leading to misleading passes/failures. Please check and fail on these errors (e.g., if err != nil { t.Fatal(...) }).

Copilot · 2026-02-06T22:32:41Z

pkg/workflow/engine_helpers_test.go

+	// Simulate the PATH setup with GOROOT pointing to the newer version
+	shellCmd := fmt.Sprintf(
+		`export GOROOT=%q; export PATH="$(find %q -maxdepth 4 -type d -name bin 2>/dev/null | tr '\n' ':')$PATH"; [ -n "$GOROOT" ] && export PATH="$GOROOT/bin:$PATH" || true; go version`,
+		filepath.Join(tmpDir, "go", "1.25.0", "x64"),
+		tmpDir,
+	)
+
+	cmd := exec.Command("bash", "-c", shellCmd)
+	output, err := cmd.Output()
+	if err != nil {
+		t.Fatalf("Failed to execute shell command: %v", err)
+	}
+
+	result := strings.TrimSpace(string(output))
+	if !strings.Contains(result, "go1.25.0") {
+		t.Errorf("Expected go1.25.0 to take precedence, but got: %s", result)
+	}


This test only asserts go version output contains go1.25.0, but it doesn’t verify that the executed go binary is the fake script created under tmpDir. If temp dir setup fails (or PATH isn’t updated as expected), the system go (which may also be 1.25.x) could make the test pass. Please assert command -v go/which go points into tmpDir (or add a unique marker to the fake script output and assert on it).

Copilot · 2026-02-06T22:32:41Z

pkg/workflow/engine_helpers_test.go

+	// GOROOT re-prepend should come AFTER the find command
+	findIdx := strings.Index(pathSetup, "find /opt/hostedtoolcache")
+	gorootIdx := strings.Index(pathSetup, "$GOROOT")
+	if gorootIdx < findIdx {
+		t.Errorf("GOROOT re-prepend should come after find command, got: %s", pathSetup)
+	}


The ordering assertion uses Index() but doesn’t guard against findIdx == -1. If the find substring ever changes (or is absent), gorootIdx < findIdx won’t trigger and the test can pass incorrectly. Please assert findIdx >= 0 (and gorootIdx >= 0) before comparing their relative order.

github-actions · 2026-02-06T22:34:17Z

✅ Changeset Generator completed successfully!

github-actions · 2026-02-06T22:34:17Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-02-06T22:34:17Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-02-06T22:34:19Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-02-06T22:37:04Z

🧪 Agent Container Tool Check

Tool	Status	Version
bash	✅	5.2.21
sh	✅	available
git	✅	2.52.0
jq	✅	1.7
yq	✅	4.52.2
curl	✅	8.5.0
gh	✅	2.86.0
node	✅	20.20.0
python3	✅	3.12.3
go	✅	1.24.12
java	⚠️	present but library issue
dotnet	⚠️	present but execution issue

Result: 10/12 tools fully working ✅ | 2/12 tools have runtime issues ⚠️

Notes:

Java executable exists at /opt/hostedtoolcache/ but has library path issues (libjli.so missing)
.NET executable exists at /usr/share/dotnet/ but has execution issues
All other critical tools (shell, git, JSON/YAML processors, HTTP, runtimes) are fully functional

AI generated by Agent Container Smoke Test

github-actions · 2026-02-06T22:39:04Z

🤖 Beep boop! The smoke test agent just passed through here on run §21768305194!

All systems nominal, tests are green ✅, and the robots are happy! 🎉

P.S. If you see any smoke, it's probably just our testing equipment working overtime. Totally normal. Nothing to worry about. Carry on! 😄

AI generated by Smoke Copilot

github-actions · 2026-02-06T22:39:10Z

Smoke Test Results

PRs Tested:

Fix Go version ordering in GetNpmBinPathSetup #14237 - Fix Go version ordering in GetNpmBinPathSetup
Refactor Dependabot Project Manager to process PRs instead of security alerts #14225 - Refactor Dependabot Project Manager to process PRs

Test Results:

✅ GitHub MCP
✅ Safe Inputs GH CLI
✅ Serena MCP
✅ Playwright
✅ File Writing
✅ Bash Tool
✅ Discussion Interaction
✅ Build gh-aw
✅ Workflow Dispatch

Overall Status: PASS ✅

@Mossaka - All tests passed successfully!

Run §21768305194

AI generated by Smoke Copilot

github-actions · 2026-02-06T22:39:23Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-02-06T22:39:37Z

Smoke test results

GitHub MCP merged PRs: ✅ Fix plugin command syntax: install plugin → plugin install; Refactor Dependabot Project Manager to process PRs instead of security alerts
safeinputs-gh PR list: ✅ Fix Go version ordering in GetNpmBinPathSetup; Review Dependabot npm PRs for docs/package.json bundle
Serena MCP activate+find_symbol: ✅ (>=3 symbols)
Playwright github title: ✅
Tavily search: ✅
File write + bash cat: ✅
Discussion comment: ✅
Build (make build): ✅
Overall: PASS

AI generated by Smoke Codex

# Conflicts: # .github/workflows/lockfile-stats.lock.yml

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-02-06T22:49:22Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-02-06T22:49:23Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-02-06T22:49:25Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-02-06T22:49:25Z

✅ Changeset Generator completed successfully!

github-actions · 2026-02-06T22:52:47Z

Agent Container Tool Check

Tool	Status	Version
bash	✅	5.2.21
sh	✅	available
git	✅	2.52.0
jq	✅	1.7
yq	✅	4.52.2
curl	✅	8.5.0
gh	✅	2.86.0
node	✅	20.20.0
python3	✅	3.12.3
go	✅	1.24.12
java	❌	Binary appears corrupted (returns bash version)
dotnet	❌	Cannot execute (renamed to bash error)

Result: 10/12 tools available ⚠️

Issues Found:

Java binary at /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/21.0.10-7/x64/bin/java exists but executes as bash
Dotnet binary at /usr/share/dotnet/dotnet reports "cannot execute dotnet when renamed to bash"
Both binaries appear to have been replaced or symlinked to bash incorrectly

This indicates a potential issue with the container image or tool installation process.

AI generated by Agent Container Smoke Test

github-actions · 2026-02-06T22:54:24Z

Smoke Test Results ✅

PR Titles:

Fix Go version ordering in GetNpmBinPathSetup #14237: Fix Go version ordering in GetNpmBinPathSetup
Review Dependabot npm PRs for docs/package.json bundle #14227: Review Dependabot npm PRs for docs/package.json bundle

Tests:

✅ GitHub MCP
✅ Safe Inputs GH CLI
✅ Serena MCP
✅ Playwright
✅ File Writing
✅ Bash Tool
✅ Discussion Interaction
✅ Build gh-aw
✅ Workflow Dispatch

Overall: PASS ✅

@Mossaka

AI generated by Smoke Copilot

github-actions · 2026-02-06T22:54:42Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-02-06T22:54:53Z

Merged PR titles: Remove anonymous bash tool syntax, require explicit configuration | Fix plugin command syntax: install plugin → plugin install
GitHub MCP (last 2 merged PRs) ✅
Safeinputs gh pr list titles: Fix Go version ordering in GetNpmBinPathSetup | Review Dependabot npm PRs for docs/package.json bundle ✅
Serena activate + find_symbol (>=3 symbols) ✅
Playwright GitHub title contains "GitHub" ✅
Tavily search results ✅
File write + cat verify ✅
Discussion query + mystical comment ✅
Build (make build) ✅
Overall: PASS

AI generated by Smoke Codex

Copilot AI review requested due to automatic review settings February 6, 2026 22:27

Copilot started reviewing on behalf of Mossaka February 6, 2026 22:28 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

Mossaka added the smoke label Feb 6, 2026

Add changeset [skip-ci]

d1f3571

github-actions bot mentioned this pull request Feb 6, 2026

Smoke Test: Copilot - 21768305194 #14238

Closed

github-actions bot added smoke-copilot and removed smoke labels Feb 6, 2026

github-actions bot added the smoke-codex label Feb 6, 2026

Mossaka and others added 2 commits February 6, 2026 22:48

Merge remote-tracking branch 'origin/main' into fix/goroot-path-ordering

e10be4f

# Conflicts: # .github/workflows/lockfile-stats.lock.yml

chore: recompile after merge with main

59b2d5f

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Mossaka added the smoke label Feb 6, 2026

github-actions bot removed the smoke label Feb 6, 2026

github-actions bot mentioned this pull request Feb 6, 2026

Smoke Test: Copilot - 21768680779 #14240

Closed

Mossaka merged commit 406bd7d into main Feb 6, 2026
94 of 95 checks passed

Mossaka deleted the fix/goroot-path-ordering branch February 6, 2026 22:55

github-actions bot mentioned this pull request Feb 7, 2026

🌱 Daily Team Evolution Insights - February 7, 2026 #14261

Closed

Conversation

Mossaka commented Feb 6, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root Cause

Fix

Test plan

Changeset

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

🧪 Agent Container Tool Check

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Smoke Test Results

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

Agent Container Tool Check

Uh oh!

github-actions bot commented Feb 6, 2026

Smoke Test Results ✅

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Mossaka commented Feb 6, 2026 •

edited by github-actions bot

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading