Draft
Conversation
Co-authored-by: pavera <660677+pavera@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove the proxy-cached feature flag from dependabot-action
Remove proxy-cached feature flag
Jan 16, 2026
Contributor
|
@copilot also do not set the PROXY_CACHE env var when running the proxy container. The proxy is also being modified to default to cached mode so this env var is no longer used |
Co-authored-by: pavera <660677+pavera@users.noreply.github.com>
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the proxy-cached feature flag that has been rolled out and is now always enabled, simplifying the codebase by removing conditional logic around proxy caching.
Changes:
- Removed the
cachedModeparameter from theProxyBuilderconstructor - Removed the
PROXY_CACHEenvironment variable from proxy container configuration - Removed the
experiments['proxy-cached']check from theUpdater.runUpdater()method
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/updater.ts | Removed the cachedMode variable and conditional logic checking for the proxy-cached experiment flag, simplified ProxyBuilder instantiation |
| src/proxy.ts | Removed cachedMode parameter from constructor and removed PROXY_CACHE environment variable from container configuration |
| dist/main/index.js | Updated compiled JavaScript to reflect source code changes |
| tests/updater-builder-integration.test.ts | Simplified test to remove cachedMode parameter, but introduced a bug with incorrect argument order |
| tests/proxy-integration.test.ts | Simplified test to remove cachedMode parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pavera
approved these changes
Jan 16, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jakecoffman
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
proxy-cachedexperiment flag has been rolled out and is now always enabled. This PR removes the conditional logic as the proxy now defaults to cached mode.Changes:
experiments['proxy-cached']check fromUpdater.runUpdater()cachedModeparameter fromProxyBuilderconstructorPROXY_CACHEenvironment variable (no longer needed as proxy defaults to cached mode)Before:
After:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.