Draft: Support providing a custom session store#917
Draft
SteveSandersonMS wants to merge 4 commits intomainfrom
Draft
Draft: Support providing a custom session store#917SteveSandersonMS wants to merge 4 commits intomainfrom
SteveSandersonMS wants to merge 4 commits intomainfrom
Conversation
- Add SessionStoreConfig interface with onLoad/onAppend/onTruncate/onListSessions/onDelete callbacks - Add sessionStore to SessionConfig and ResumeSessionConfig - Add ListSessionsOptions type for listSessions with session store - Update CopilotClient.createSession/resumeSession to send sessionStore descriptor and register RPC handlers - Update listSessions to accept ListSessionsOptions - Register sessionStore.* RPC request handlers on connection setup - Add E2E tests verifying persist, resume, listSessions, and descriptor mismatch Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add support for the 'client' section of api.schema.json: - Generate typed handler interfaces (e.g., SessionStoreHandler) - Generate ClientApiHandlers composite interface - Generate registerClientApiHandlers() registration function - Handle methods with no result type (void return) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace hand-written onRequest registrations with generated registerClientApiHandlers() and a routing SessionStoreHandler - Re-export SessionStoreHandler and ClientApiHandlers from index.ts - Fix listSessions concurrency: replace singleton listSessionsStore with a Map keyed by incrementing ID - Add cleanup of sessionStoreConfigs and listSessionsStores on stop() and forceStop() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add test verifying onDelete is called when deleting a session - Remove unused getFinalAssistantMessage import Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not yet ready.