Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the StartProxyConnectionChecks feature flag that was introduced in PR #3466 to gate connection checks to private registries in the start-proxy action. The feature has been fully rolled out and is now stable, so the gate is no longer needed. The connection checks are now always performed.
Changes:
- Removed the
StartProxyConnectionChecksfeature flag from theFeatureenum andfeatureConfigobject - Removed the feature flag check that gated the
checkConnectionscall instart-proxy-action.ts - Updated all generated JavaScript files in
lib/to reflect the TypeScript changes
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/start-proxy-action.ts | Removed feature flag check, now always calls checkConnections |
| src/feature-flags.ts | Removed StartProxyConnectionChecks enum entry and config |
| lib/start-proxy-action.js | Generated JS reflecting removal of feature flag check |
| lib/feature-flags.ts (via multiple lib/*.js files) | Generated JS reflecting removal of feature flag definition |
| lib/upload-sarif-action.js | Generated JS with removed feature flag definition |
| lib/upload-sarif-action-post.js | Generated JS with removed feature flag definition |
| lib/upload-lib.js | Generated JS with removed feature flag definition |
| lib/start-proxy-action-post.js | Generated JS with removed feature flag definition |
| lib/setup-codeql-action.js | Generated JS with removed feature flag definition |
| lib/resolve-environment-action.js | Generated JS with removed feature flag definition |
| lib/init-action.js | Generated JS with removed feature flag definition |
| lib/init-action-post.js | Generated JS with removed feature flag definition |
| lib/autobuild-action.js | Generated JS with removed feature flag definition |
| lib/analyze-action.js | Generated JS with removed feature flag definition |
| lib/analyze-action-post.js | Generated JS with removed feature flag definition |
henrymercer
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the FF added in #3466 since this is now fully rolled out and appears to be stable.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist