Replace github-script with file-based approach to avoid large JSON output max limit#177
Open
lindseywild wants to merge 2 commits intomainfrom
Open
Replace github-script with file-based approach to avoid large JSON output max limit#177lindseywild wants to merge 2 commits intomainfrom
lindseywild wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the root composite GitHub Action to avoid Linux ARG_MAX failures when handling large JSON payloads by moving results processing to a file-based flow, while preserving the existing results output and adding a new file-path output for large datasets.
Changes:
- Replaces the
actions/github-script@v8“Set results output” step with bash + inline Node that reads/writes JSON via files. - Adds a new
results_fileoutput pointing to the generatedscanner-results.json. - Switches caching of results from value-based
gh-cache/cacheto file-basedgh-cache/saveby copyingscanner-results.jsonto the cache path first.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lindseywild
force-pushed
the
replace-github-script-file-based-argmax
branch
2 times, most recently
from
bb1f458 to
1b3db1c
Compare
lindseywild
changed the title
The 'Set results output' step used actions/github-script@v8, which interpolated large filings JSON (~138KB+) as a CLI argument to node. This exceeded Linux's ARG_MAX limit, causing 'Argument list too long' errors. Changes: - Replace github-script step with bash heredoc + node heredoc approach that writes data to temp files, avoiding CLI arg limits - Add results_file output for consumers needing large dataset support - Switch cache saving from value-based to file-based using gh-cache/save - Keep results output for backward compatibility Resolves github/accessibility#10354 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lindseywild
force-pushed
the
replace-github-script-file-based-argmax
branch
from
1b3db1c to
b55df88
Compare
The 'Output cached value' step cats a JSON file into GITHUB_OUTPUT followed by an EOF delimiter, but if the file has no trailing newline the delimiter lands on the same line as the content, causing: 'Invalid value. Matching delimiter not found EOF' Add a bare echo to ensure a newline before the closing delimiter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
abdulahmad307
approved these changes
Mar 27, 2026
Contributor
abdulahmad307
left a comment
abdulahmad307
left a comment
There was a problem hiding this comment.
the code looks good. I think we need to go through the run logs and make sure issues were opened (or re-opened) correctly before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
actions/github-script@v8"Set results output" step with a file-based bash/node approach to avoid Linux'sARG_MAXlimit when processing large JSON payloads (~138KB+).Problem
The previous implementation interpolated large
filingsJSON directly as a CLI argument tonodeviagithub-script. This exceeded theARG_MAXlimit on Linux runners, causing:Changes
Replaced
github-script@v8step with two bash steps:scanner-results.jsonAdded
results_fileoutput — a new composite action output pointing to the JSON file, for consumers that need to handle large datasets without output size limits.Switched cache saving from the value-based
gh-cache/cacheaction to the file-basedgh-cache/saveaction, copyingscanner-results.jsonto the cache key path first.Backward compatibility
resultsoutput is still set viaGITHUB_OUTPUTheredoc delimiter for existing consumers.results_fileoutput is additive and opt-in.[Staff only] Resolves github/accessibility#10354