Fix use case resulting 4GB+ files created as 0 bytes on disk#6077
Open
LordKiRon wants to merge 3 commits intogit-for-windows:mainfrom
Open
Fix use case resulting 4GB+ files created as 0 bytes on disk#6077LordKiRon wants to merge 3 commits intogit-for-windows:mainfrom
LordKiRon wants to merge 3 commits intogit-for-windows:mainfrom
Conversation
Signed-off-by: LordKiRon <lordkiron@gmail.com>
1 task
Signed-off-by: LordKiRon <lordkiron@gmail.com>
LordKiRon
force-pushed
the
0sizeFixOnly
branch
from
29e7517 to
d4897d0
Compare
Author
|
Found another potensial issue during my testing in 4GB files in history that need to go in as part of this fix |
Signed-off-by: LordKiRon <lordkiron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last part of 4GB+ issues fix
Together with:
#6069
and
#6076
The main idea is to use special function operating in size_t to treat files >=4GB , while using old flow for everything else.
The change to the data type in structure is mitigate by using temporary variables to avoid significant refactoring of function signatures.
This package of 3 PRs is minimalistic and does the job, however on my strong opinion the proper fix is just to change all size related code from "unsigned long" to "size_t" this is a way more proper fix.