Skip to content

perf: Use FilenameCache in profilers#2919

Open
sl0thentr0py wants to merge 1 commit intoperf/load-path-and-filename-cachingfrom
neel/profiler-filename-cache
Open

perf: Use FilenameCache in profilers#2919
sl0thentr0py wants to merge 1 commit intoperf/load-path-and-filename-cachingfrom
neel/profiler-filename-cache

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

No description provided.

@sl0thentr0py sl0thentr0py requested review from dingsdax and solnic March 27, 2026 15:34
end

prefix ? abs_path[prefix.to_s.chomp(File::SEPARATOR).length + 1..-1] : abs_path
@filename_cache.compute_filename(abs_path, in_app, true)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why default strip_backtrace_load_path to true here?

@project_root = configuration.project_root
@app_dirs_pattern = configuration.app_dirs_pattern
@in_app_pattern = Regexp.new("^(#{@project_root}/)?#{@app_dirs_pattern}")
@filename_cache = configuration.stacktrace_builder.filename_cache
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth to test that filename_cache is shared between profiler & stacktrace_builder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants