Skip to content

test(pyramid): Support alpha suffixes in version parsing #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 2 commits into from
Mar 10, 2026
+2 −1
Merged

test(pyramid): Support alpha suffixes in version parsing #5618

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fa6761
test(pyramid): Support alpha suffixes in version parsing
alexander-alderman-webb Mar 9, 2026
2209377
.
alexander-alderman-webb Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/integrations/pyramid/test_pyramid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import pytest
from pyramid.authorization import ACLAuthorizationPolicy
from pyramid.response import Response
from packaging.version import Version
from werkzeug.test import Client

from sentry_sdk import capture_message, add_breadcrumb
Expand All @@ -18,7 +19,7 @@
try:
from importlib.metadata import version

PYRAMID_VERSION = tuple(map(int, version("pyramid").split(".")))
PYRAMID_VERSION = Version(version("pyramid")).release

Check warning on line 22 in tests/integrations/pyramid/test_pyramid.py

View workflow job for this annotation

GitHub Actions / warden: code-review

Fallback code path in except block doesn't handle alpha suffixes 

The PR fixes version parsing for Python 3.8+ by using `packaging.version.Version(...).release`, but the fallback `except ImportError` block (lines 26-30 for Python < 3.8) still uses `map(int, version.split('.'))` which will raise `ValueError` on versions with alpha suffixes like '2.0a1'. This inconsistency means the fix is incomplete - tests would still fail on Python 3.6/3.7 with alpha pyramid versions.

except ImportError:
# < py3.8
Expand Down
Loading