Skip to content

ref: Add active to StreamedSpan (3)#5590

Merged
sentrivana merged 2 commits intoivana/span-first-2-tweak-span-interfacefrom
ivana/span-first-3-add-active
Mar 5, 2026
Merged

ref: Add active to StreamedSpan (3)#5590
sentrivana merged 2 commits intoivana/span-first-2-tweak-span-interfacefrom
ivana/span-first-3-add-active

Conversation

@sentrivana
Copy link
Contributor

Description

active is also part of the public API (start_span(name="...", active=False)), so it'll need to propagate to the StreamedSpan class.

Issues

Reminders

@sentrivana sentrivana changed the title ref: Add active to StreamedSpan ref: Add active to StreamedSpan (3) Mar 5, 2026
@sentrivana sentrivana force-pushed the ivana/span-first-3-add-active branch from 1b8c7f8 to 6a85f5e Compare March 5, 2026 11:23
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Codecov Results 📊

1869 passed | ⏭️ 153 skipped | Total: 2022 | Pass Rate: 92.43% | Execution Time: 3m 15s

All tests are passing successfully.

❌ Patch coverage is 50.00%. Project has 11831 uncovered lines.

Files with missing lines (1)
File Patch % Lines
traces.py 51.95% ⚠️ 37 Missing

Generated by Codecov Action

@sentrivana sentrivana marked this pull request as ready for review March 5, 2026 11:34
@sentrivana sentrivana requested a review from a team as a code owner March 5, 2026 11:34
@sentrivana sentrivana force-pushed the ivana/span-first-3-add-active branch from a655dca to 47e6211 Compare March 5, 2026 11:40
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@sentrivana sentrivana force-pushed the ivana/span-first-2-tweak-span-interface branch from 5023c76 to 1a11da9 Compare March 5, 2026 11:42
@sentrivana sentrivana force-pushed the ivana/span-first-3-add-active branch from 47e6211 to 418572c Compare March 5, 2026 11:43
@sentrivana sentrivana merged commit 065d55b into ivana/span-first-2-tweak-span-interface Mar 5, 2026
21 checks passed
@sentrivana sentrivana deleted the ivana/span-first-3-add-active branch March 5, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants