ref: Add active to StreamedSpan (3)#5590
Merged
sentrivana merged 2 commits intoivana/span-first-2-tweak-span-interfacefrom Mar 5, 2026
Merged
ref: Add active to StreamedSpan (3)#5590sentrivana merged 2 commits intoivana/span-first-2-tweak-span-interfacefrom
active to StreamedSpan (3)#5590sentrivana merged 2 commits intoivana/span-first-2-tweak-span-interfacefrom
Conversation
active to StreamedSpan (3)
1b8c7f8 to
6a85f5e
Compare
Contributor
Codecov Results 📊✅ 1869 passed | ⏭️ 153 skipped | Total: 2022 | Pass Rate: 92.43% | Execution Time: 3m 15s All tests are passing successfully. ❌ Patch coverage is 50.00%. Project has 11831 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
a655dca to
47e6211
Compare
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
alexander-alderman-webb
approved these changes
Mar 5, 2026
5023c76 to
1a11da9
Compare
47e6211 to
418572c
Compare
065d55b
into
ivana/span-first-2-tweak-span-interface
21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
activeis also part of the public API (start_span(name="...", active=False)), so it'll need to propagate to theStreamedSpanclass.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)