Skip to content

ref: Tweak StreamedSpan interface (2)#5589

Merged
sentrivana merged 4 commits intomasterfrom
ivana/span-first-2-tweak-span-interface
Mar 5, 2026
Merged

ref: Tweak StreamedSpan interface (2)#5589
sentrivana merged 4 commits intomasterfrom
ivana/span-first-2-tweak-span-interface

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 5, 2026

Description

  • add a __repr__
  • remove set_x() methods, set_http_status to keep API surface minimal
  • remove getters/setters in favor of properties where applicable (status, name)
  • add a warning when setting an unsupported span status value

Issues

Reminders

@sentrivana sentrivana changed the title ref: Tweak StreamedSpan interface ref: Tweak StreamedSpan interface (2) Mar 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Codecov Results 📊

14 passed | Total: 14 | Pass Rate: 100% | Execution Time: 3.60s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 57.14%. Project has 14994 uncovered lines.
✅ Project coverage is 24.63%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
traces.py 51.95% ⚠️ 37 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    24.23%    24.63%     +0.4%
==========================================
  Files          189       189         —
  Lines        19772     19894      +122
  Branches      6835      6458      -377
==========================================
+ Hits          4790      4900      +110
- Misses       14982     14994       +12
- Partials       385       381        -4

Generated by Codecov Action

@sentrivana sentrivana marked this pull request as ready for review March 5, 2026 11:34
@sentrivana sentrivana requested a review from a team as a code owner March 5, 2026 11:34
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

Base automatically changed from ivana/span-first-1-remove-flags to master March 5, 2026 11:41
@sentrivana sentrivana force-pushed the ivana/span-first-2-tweak-span-interface branch from 5023c76 to 1a11da9 Compare March 5, 2026 11:42
@sentrivana sentrivana enabled auto-merge (squash) March 5, 2026 11:43
### Description
`active` is also part of the public API (`start_span(name="...",
active=False)`), so it'll need to propagate to the `StreamedSpan` class.

#### Issues
<!--
* resolves: #1234
* resolves: LIN-1234
-->

#### Reminders
- Please add tests to validate your changes, and lint your code using
`tox -e linters`.
- Add GH Issue ID _&_ Linear ID (if applicable)
- PR title should use [conventional
commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type)
style (`feat:`, `fix:`, `ref:`, `meta:`)
- For external contributors:
[CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md),
[Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord
community](https://discord.gg/Ww9hbqr)
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@sentrivana sentrivana merged commit e9d6782 into master Mar 5, 2026
160 checks passed
@sentrivana sentrivana deleted the ivana/span-first-2-tweak-span-interface branch March 5, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants