ref: Tweak StreamedSpan interface (2)#5589
Conversation
Codecov Results 📊✅ 14 passed | Total: 14 | Pass Rate: 100% | Execution Time: 3.60s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 57.14%. Project has 14994 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 24.23% 24.63% +0.4%
==========================================
Files 189 189 —
Lines 19772 19894 +122
Branches 6835 6458 -377
==========================================
+ Hits 4790 4900 +110
- Misses 14982 14994 +12
- Partials 385 381 -4Generated by Codecov Action |
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
very nice
5023c76 to
1a11da9
Compare
### Description `active` is also part of the public API (`start_span(name="...", active=False)`), so it'll need to propagate to the `StreamedSpan` class. #### Issues <!-- * resolves: #1234 * resolves: LIN-1234 --> #### Reminders - Please add tests to validate your changes, and lint your code using `tox -e linters`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Description
__repr__set_x()methods,set_http_statusto keep API surface minimalIssues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)