Fix transaction naming for django-ninja endpoints with transaction_style="function_name" #5474
Open
avilaton wants to merge 1 commit intogetsentry:masterfrom
Open
Fix transaction naming for django-ninja endpoints with transaction_style="function_name" #5474avilaton wants to merge 1 commit intogetsentry:masterfrom
avilaton wants to merge 1 commit intogetsentry:masterfrom
Conversation
…yle="function_name" (#1) * Initial plan * Add django-ninja support for transaction_style=function_name Co-authored-by: avilaton <2209022+avilaton@users.noreply.github.com> * Address code review feedback: fix exception handling and improve test Co-authored-by: avilaton <2209022+avilaton@users.noreply.github.com> * Fix trailing whitespace in docstring Co-authored-by: avilaton <2209022+avilaton@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: avilaton <2209022+avilaton@users.noreply.github.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DISCLAIMER: We patched django using a middleware to fix this and wanted to contribute it back to sentry, delegated this to copilot and it looks ok, no intention to be ai-slop, just wanted to raise the issue here.
Django-ninja endpoints were all grouped under
ninja.operation.PathView._sync_viewwhen usingtransaction_style="function_name", making it impossible to distinguish between different API endpoints in Sentry.Django's
resolve()returns the PathView wrapper function instead of the actual endpoint. The wrapper is shared across all endpoints on the same path, causing the grouping issue.Changes
_unwrap_django_ninja_view()- Detects PathView wrappers by checking__qualname__, extracts the PathView instance from the closure, matches the HTTP method to the correct Operation, and returns the actual endpoint function_set_transaction_name_and_source()- Calls unwrapper whentransaction_style="function_name"before extracting the transaction namefunction_nameandurltransaction styles work correctly with ninja endpointsExample
Before this change, all these endpoints would be grouped as
ninja.operation.PathView._sync_view:After this change, they get distinct names:
myapp.views.list_usersandmyapp.views.create_user.