fix(openai-agents): Patch tool functions following library refactor#5445
Merged
alexander-alderman-webb merged 6 commits intomasterfrom Feb 13, 2026
Merged
fix(openai-agents): Patch tool functions following library refactor#5445alexander-alderman-webb merged 6 commits intomasterfrom
alexander-alderman-webb merged 6 commits intomasterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 6.00s All tests are passing successfully. ❌ Patch coverage is 5.00%. Project has 13668 uncovered lines. Files with missing lines (180)
Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
sl0thentr0py
requested changes
Feb 11, 2026
|
|
||
|
|
||
| def _patch_run_get_all_tools() -> None: | ||
| agents.run.get_all_tools = _create_run_loop_get_all_tools_wrapper( |
Member
There was a problem hiding this comment.
we're creating a lot of random indirection and cognitive overhead with these wrappers. I would just move the patching logic here in this function and remove those wrappers and just keep the _get_all_tools in the tools.py file.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
sl0thentr0py
requested changes
Feb 11, 2026
| @staticmethod | ||
| def setup_once() -> None: | ||
| _patch_error_tracing() | ||
| _patch_tools() |
Member
There was a problem hiding this comment.
let's keep _patch_tools for the isolation and add the tools stuff in there
Contributor
Author
There was a problem hiding this comment.
I want to avoid having the same if condition in all the patch_* functions that boils down to checking the version. Could we consider breaking into _patch_run_get_all_tools() and _patch_agent_runner_get_all_tools(), or do we want different names for these functions that are not based on the location+name of what we're patching?
Member
There was a problem hiding this comment.
ok then keep this for now, we'll look at the shape of the __init__ file at the end, and we remove all the wrappers first
sl0thentr0py
approved these changes
Feb 11, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+102
to
+111
| @wraps(run_loop.get_all_tools) | ||
| async def new_wrapped_get_all_tools( | ||
| agent: "agents.Agent", | ||
| context_wrapper: "agents.RunContextWrapper", | ||
| ) -> "list[agents.Tool]": | ||
| return await _get_all_tools( | ||
| run_loop.get_all_tools, agent, context_wrapper | ||
| ) | ||
|
|
||
| agents.run.get_all_tools = new_wrapped_get_all_tools |
There was a problem hiding this comment.
Bug: The code accesses run_loop.get_all_tools after a version check, but doesn't verify that run_loop isn't None from a failed import, which can cause an AttributeError.
Severity: CRITICAL
Suggested Fix
Add a if run_loop is not None: check after the version check and before the code block that attempts to access run_loop.get_all_tools to ensure the object exists before it is used.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: sentry_sdk/integrations/openai_agents/__init__.py#L102-L111
Potential issue: In the OpenAI Agents integration, the code checks if the library
version is `0.8` or higher and, if so, attempts to access `run_loop.get_all_tools`.
However, the `run_loop` object is imported within a `try...except` block that sets
`run_loop = None` if the import fails. The code does not check if `run_loop` is `None`
after the version check but before accessing its attributes. This can lead to an
`AttributeError: 'NoneType' object has no attribute 'get_all_tools'` if the import fails
on a supported version, for instance, due to a corrupted installation. This error occurs
during SDK initialization and can prevent the application from starting.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
AgentRunner._get_all_tools()class method has been moved to the functionagents.run_internal.turn_preparation.get_all_tools().Patch the new function by re-using existing wrapper logic.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)