feat(core): [Global Attributes 4] Detect integer attribute type correctly for all integer Number subtypes#5122
Open
adinauer wants to merge 2 commits intofeat/scope-attributes-sample-e2efrom
Conversation
…ubtypes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Bug Fixes 🐛
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
Contributor
Performance metrics 🚀
|
Contributor
|
This was referenced Feb 26, 2026
Member
Author
|
PR Stack (Global Attributes):
|
4 tasks
Member
Author
|
@sentry review |
Member
Author
|
cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
SentryAttributeType.inferFrom()only checked forIntegerwhen detecting theINTEGERtype. All other integer-likeNumbersubtypes (Long,Short,Byte,BigInteger,AtomicInteger,AtomicLong) fell through to theNumbercatch-all and were incorrectly classified asDOUBLE.Extended the
INTEGERcheck to cover all integer-likeNumbersubtypes. Floating-point types (Float,Double,BigDecimal) still correctly map toDOUBLE.💡 Motivation and Context
Numbersubtypes #5076💚 How did you test it?
Added
SentryAttributeTypeTestwith tests for all Number subtypes (Integer,Long,Short,Byte,BigInteger,AtomicInteger,AtomicLong,Double,Float,BigDecimal) as well asBoolean,String, andnull.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps