[quick_actions] Remove usesCleartextTraffic #11064
[quick_actions] Remove usesCleartextTraffic #11064auto-submit[bot] merged 5 commits intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request updates the Android configuration for the quick_actions example app's debug build. It replaces the deprecated android:usesCleartextTraffic attribute with a networkSecurityConfig file. This change maintains the ability for cleartext traffic in debug mode, which is necessary for Flutter development tools, while using the modern Android configuration approach. I have provided one suggestion to improve the security of this new configuration by restricting cleartext traffic to only necessary local domains.
...uick_actions/quick_actions/example/android/app/src/debug/res/xml/network_security_config.xml
Outdated
Show resolved
Hide resolved
...uick_actions/quick_actions/example/android/app/src/debug/res/xml/network_security_config.xml
Outdated
Show resolved
Hide resolved
|
test-exempt: configuration change |
|
No changelog needed - configuration change for example app. |
Removes deprecated usesCleartextTraffic.
Addresses: #182553
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).