Make error injectable and cleanup not needed code.#840
Open
polina-c wants to merge 28 commits intoflutter:mainfrom
Open
Make error injectable and cleanup not needed code.#840polina-c wants to merge 28 commits intoflutter:mainfrom
polina-c wants to merge 28 commits intoflutter:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request performs a significant refactoring of the ui_primitives package, removing several legacy foundation files and consolidating core types and error reporting into new error_reporter.dart and primitives.dart files. The existing UiError system is replaced by a new FrameworkErrorReporter architecture, and core classes like ChangeNotifier and ValueNotifier have been updated to use this new reporter. Review feedback suggests that FrameworkErrorDetails should be a plain data class rather than extending Error, and identifies a duplicate copyright header in the new primitives file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #834