feat: add storage.total_limit_size support to http output#1865
Merged
joshuabaird merged 3 commits intofluent:masterfrom Feb 12, 2026
Merged
feat: add storage.total_limit_size support to http output#1865joshuabaird merged 3 commits intofluent:masterfrom
joshuabaird merged 3 commits intofluent:masterfrom
Conversation
10a7063 to
2120bf9
Compare
Fixes fluent#1852 Added the TotalLimitSize field to the HTTP output plugin struct and its rendering in the Params() method, following the same pattern used in elasticsearch, opentelemetry, syslog, loki, kafka, and opensearch output plugins. Changes: - Added TotalLimitSize field to HTTP struct in http_types.go - Added storage.total_limit_size config rendering in Params() - Added unit test in http_types_test.go - Regenerated CRDs via make manifests - Regenerated DeepCopy via make generate - Regenerated docs via doc-gen Signed-off-by: JeelDasvani <jeeldasvani@users.noreply.github.com> Signed-off-by: Jeel Dasvani <71589203+JeelDasvani@users.noreply.github.com>
cdb83c0 to
8f6d22c
Compare
Contributor
Author
|
Hey @joshuabaird , looks like 7 workflows are awaiting approval to run. |
joshuabaird
approved these changes
Feb 12, 2026
Collaborator
joshuabaird
left a comment
There was a problem hiding this comment.
Thanks for your contribution, @JeelDasvani!
Contributor
Author
|
Thanks @joshuabaird for the review and for merging the PR. happy to contribute and looking forward to helping more with the project. |
joshuabaird
pushed a commit
to joshuabaird/fluent-operator
that referenced
this pull request
Feb 13, 2026
Fixes fluent#1852 Added the TotalLimitSize field to the HTTP output plugin struct and its rendering in the Params() method, following the same pattern used in elasticsearch, opentelemetry, syslog, loki, kafka, and opensearch output plugins. Changes: - Added TotalLimitSize field to HTTP struct in http_types.go - Added storage.total_limit_size config rendering in Params() - Added unit test in http_types_test.go - Regenerated CRDs via make manifests - Regenerated DeepCopy via make generate - Regenerated docs via doc-gen Signed-off-by: JeelDasvani <jeeldasvani@users.noreply.github.com> Signed-off-by: Jeel Dasvani <71589203+JeelDasvani@users.noreply.github.com>
joshuabaird
pushed a commit
to joshuabaird/fluent-operator
that referenced
this pull request
Feb 27, 2026
Fixes fluent#1852 Added the TotalLimitSize field to the HTTP output plugin struct and its rendering in the Params() method, following the same pattern used in elasticsearch, opentelemetry, syslog, loki, kafka, and opensearch output plugins. Changes: - Added TotalLimitSize field to HTTP struct in http_types.go - Added storage.total_limit_size config rendering in Params() - Added unit test in http_types_test.go - Regenerated CRDs via make manifests - Regenerated DeepCopy via make generate - Regenerated docs via doc-gen Signed-off-by: JeelDasvani <jeeldasvani@users.noreply.github.com> Signed-off-by: Jeel Dasvani <71589203+JeelDasvani@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds
storage.total_limit_sizesupport to the HTTP output plugin, allowing users to configure disk-based buffering limits through Kubernetes manifests.Fixes #1852
Changes
TotalLimitSizefield to theHTTPoutput struct inhttp_types.gostorage.total_limit_sizeconfig rendering in theParams()methodhttp_types_test.go) verifying correct renderingmake manifestsmake generatego run ./cmd/doc-gen/main.goPattern
This follows the exact same pattern already used in 6 other output plugins:
Testing
go vet— cleango test ./apis/fluentbit/v1alpha2/... -v— all 12 tests passtotalLimitSizeunder the HTTP output specExample usage