dataconnect: maxAge implemented for offline caching#7848
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a maxAge parameter to the CacheSettings class, enabling offline caching to respect the maximum age of cached query results. The changes include modifications to the CHANGELOG.md, api.txt, CacheSettings.kt, DataConnectGrpcRPCs.kt, FirebaseDataConnectImpl.kt, DataConnectCacheDatabase.kt, DataConnectCacheDatabaseMigrator.kt, sdk.proto, CacheSettingsUnitTest.kt, DataConnectGrpcRPCsUnitTest.kt, and several test utility files. The code review comment suggests removing the redundant normalizedDuration variable in DataConnectCacheDatabase.kt.
...taconnect/src/main/kotlin/com/google/firebase/dataconnect/sqlite/DataConnectCacheDatabase.kt
Show resolved
Hide resolved
…d of standard deviation for less flaky testing.
…hEvenNumDigitsDistributionUnitTest
…SignificanceResult
This PR introduces support for
maxAgeinfirebase-dataconnect, allowing developers to specify the maximum age of a cached response that is acceptable.Highlights
maxAgeSupport: TheCacheSettingsclass now includes amaxAgeproperty to control the freshness of cached data.DataConnectGrpcRPCsclass now checks if a cached result is stale based onmaxAgeand fetches from the server if it is.Changelog
maxAgefeature.maxAgeproperty to theCacheSettingsclass.executeQueryto check if a cached result is stale based onmaxAge.insertQueryResultto store themaxAgewith the cached result.getQueryResultto check if a cached result is stale based onmaxAge.insertQueryResultto store themaxAgewith the cached result.maxAgefeature.Intvalues with an even distribution of the number of digits.Longvalues with an even distribution of the number of digits.Durationobjects.IntRange.intersectandLongRange.intersectextension functions.intWithEvenNumDigitsDistributiontest utility.longWithEvenNumDigitsDistributiontest utility.maxAgeArbtest utility.durationtest utility.