Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
Generated by 🚫 Danger |
Implemented `downsizeBitmapIfNeeded` to scale down bitmaps before they are used in `ImagePart` conversions. This ensures that the shorter dimension of the bitmap does not exceed 768 pixels, optimizing image processing for ML Kit. Manually tested using a Pixel10 and a 10MB image Change will be rolled back after bumping dep on ML Kit.
Introduced `withFlowFallback` to handle exceptions during `generateContentStream` flow collection. Flows exception should be handled at **collection time** rather than at creation time. Also, fallback should only occurs if no items have been successfully emitted by the default model, preventing inconsistent responses from mixed sources. Tests were updated to validate this behavior, including scenarios with partial emissions and various exception types.
The `parametersSchema`, `parametersJsonSchema` and `responseJsonSchema` fields in the `FunctionDeclaration` constructor now have default `null` values. This makes them optional during object construction, and doesn't include them in the serialized request. Having both `parametersSchema` and `parametersJsonSchema` in the serialized requests caused them to be rejected by the service. Fix has been tested manually using the Firebase AI Quickstart app in https://github.com/firebase/quickstart-android/tree/master/firebase-ai Internal b/487646970
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for release m177