refactor: remove any and as throughout codebase#1323
refactor: remove any and as throughout codebase#1323jescalada wants to merge 53 commits intofinos:mainfrom
any and as throughout codebase#1323Conversation
…ttestation definition
…elds, remove any in src/proxy/routes/index
Sets stub types to (`ReturnType<typeof vi.fn>`) to remove the any type
…for req and stubs
…/jescalada/git-proxy into 1174-remove-any-and-as-ts-wrapup
…y, jwtAuthHandler)
… for edge case tests
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
|
@kriswest This one's ready for review! |
|
@jescalada this has picked up some conflicts - are you able to resolve and then hit me over the head to review it? |
|
@kriswest Should be ready to review now 😃 |
|
By the way, I'm not sure which missing coverage lines aren't already dealt with in #1356, so I suggest ignoring the lost coverage here and dealing with the aftermath in that PR instead. |
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Another monster contribution, much appreciated. I've left a handful of comments for you to look at (I think a couple of removed test cases are still needed and a util function could go in for handling error message extraction - which could allow us to turn on stack traces) - however the majority LGTM.
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
… match original ones
…ry proxy variable
…or tab identifier
|
@kriswest Ready for a final look! |
2 participants
Fixes #1174.