Remove redundant global path var and fix memory corruption#481
Merged
troglobit merged 1 commit intofinit-project:masterfrom Mar 4, 2026
Merged
Remove redundant global path var and fix memory corruption#481troglobit merged 1 commit intofinit-project:masterfrom
troglobit merged 1 commit intofinit-project:masterfrom
Conversation
Collaborator
|
Nice catch on this, btw! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #479
The use of a global static variable here serves no practical purpose, as it is being assigned only from the
conf_parse_cmdlinefunction, where this logic is arguably redundant, because env vars passed by the kernel are already in memory. Therefore, subsequent check and re-assignment of an already existing value is not needed and actually causes an issue described in the link above.While fixing
path, also refactored the use ofshell, to the same effect, even though no particular issue has been reported so far.