Draft
Conversation
Separate Seonbi API call logic (fetch, request body, response parsing, error handling) into a dedicated function for better testability and reusability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Allow using SEONBI_NATIVE=true to perform Seonbi transformations locally via napi-rs bindings instead of requiring an external HTTP API (SEONBI_URL). Falls back to SEONBI_URL if native is unavailable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Separate language detection and transformer selection logic from formatPostContent() into a dedicated getPostContentTransformer() function and a PostContentTransformer type alias. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Clarify that this function uses the Seonbi HTTP API, distinguishing it from transformWithSeonbiNative which uses the native binding. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is an experimental PR to see if seonbi-rs, a Rust port of Seonbi, can be applied. This allows for the conversion of mixed Korean and Hanja text without having to run an additional Seonbi API server.
It can be activated via the
SEONBI_NATIVE=trueenvironment variable. The priority order isSEONBI_NATIVE->SEONBI_URL-> nothing.Screenshots
漢字 變換 테스트 中was transformed like the following screenshot in my local environment (phanpy):