Skip to content

Fix DeadVariable and NotInvokedPrivateMethod: Remove unused code #55503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdvacca wants to merge 3 commits into from
Closed

Fix DeadVariable and NotInvokedPrivateMethod: Remove unused code #55503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b86232d
Fix NonStaticNestedClass: Make inner class static (#55501)
mdvacca Feb 12, 2026
29f636a
Fix MissingOverrideAnnotation: Add @Override to flex methods (#55502)
mdvacca Feb 12, 2026
b503a96
Fix DeadVariable and NotInvokedPrivateMethod: Remove unused code (#55…
mdvacca Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,18 +1012,18 @@ public void setTouchCancel(@NonNull T view, boolean value) {
* especially helpful for views that are recycled so we can retain and restore the original
* listener upon recycling (onDropViewInstance).
*/
private class BaseVMFocusChangeListener<V extends View> implements OnFocusChangeListener {
private static class BaseVMFocusChangeListener implements OnFocusChangeListener {
private @Nullable OnFocusChangeListener mOriginalFocusChangeListener;

public BaseVMFocusChangeListener(@Nullable OnFocusChangeListener originalFocusChangeListener) {
mOriginalFocusChangeListener = originalFocusChangeListener;
}

public void attach(T view) {
public void attach(View view) {
view.setOnFocusChangeListener(this);
}

public void detach(T view) {
public void detach(View view) {
view.setOnFocusChangeListener(mOriginalFocusChangeListener);
}

Expand Down
3 changes: 3 additions & 0 deletions ...eact-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/LayoutShadowNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ public void setMaxHeight(Dynamic maxHeight) {
maxHeight.recycle();
}

@Override
@ReactProp(name = ViewProps.FLEX, defaultFloat = 0f)
public void setFlex(float flex) {
if (isVirtual()) {
Expand All @@ -238,6 +239,7 @@ public void setFlex(float flex) {
super.setFlex(flex);
}

@Override
@ReactProp(name = ViewProps.FLEX_GROW, defaultFloat = 0f)
public void setFlexGrow(float flexGrow) {
if (isVirtual()) {
Expand Down Expand Up @@ -309,6 +311,7 @@ public void setGap(Dynamic gap) {
gap.recycle();
}

@Override
@ReactProp(name = ViewProps.FLEX_SHRINK, defaultFloat = 0f)
public void setFlexShrink(float flexShrink) {
if (isVirtual()) {
Expand Down
8 changes: 0 additions & 8 deletions ...ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyOptimizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,12 +231,6 @@ public void onBatchComplete() {
mTagsWithLayoutVisited.clear();
}

private NodeIndexPair walkUpUntilNativeKindIsParent(
ReactShadowNode node, int indexInNativeChildren) {
// Logic removed due to NativeKind removal
return new NodeIndexPair(node, indexInNativeChildren);
}

private void addNodeToNode(ReactShadowNode parent, ReactShadowNode child, int index) {
// Logic removed due to NativeKind removal
}
Expand Down Expand Up @@ -289,8 +283,6 @@ private void applyLayoutBase(ReactShadowNode node) {
}
mTagsWithLayoutVisited.put(tag, true);

ReactShadowNode parent = node.getParent();

// We use screenX/screenY (which round to integer pixels) at each node in the hierarchy to
// emulate what the layout would look like if it were actually built with native views which
// have to have integral top/left/bottom/right values
Expand Down
Loading