Fix multiple lint warnings in NativeViewHierarchyManager#55499
Closed
mdvacca wants to merge 1 commit intofacebook:mainfrom
Closed
Fix multiple lint warnings in NativeViewHierarchyManager#55499mdvacca wants to merge 1 commit intofacebook:mainfrom
mdvacca wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
mdvacca
force-pushed
the
export-D91992935
branch
2 times, most recently
from
e92c49d to
7866adf
Compare
mdvacca
force-pushed
the
export-D91992935
branch
from
7866adf to
2945985
Compare
) Summary: Fixed multiple lint warnings in NativeViewHierarchyManager.java: 1. ClownyBooleanExpression: Added SuppressLint for intentionally disabled DEBUG_MODE (ReactBuildConfig.DEBUG && false). This pattern is used to easily enable debug mode by changing to just ReactBuildConfig.DEBUG. 2. NullableAnnotationShouldNotAddToPrimitiveTypes: Removed Nullable from getInstanceHandle() which returns a primitive long. Primitives can't be null; this method throws exceptions instead of returning null. 3. NotInvokedPrivateMethod: Removed unused private methods arrayContains() and getReactContextForView() which were dead code. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D91992935
mdvacca
force-pushed
the
export-D91992935
branch
from
2945985 to
bdfac9c
Compare
Collaborator
|
This pull request was successfully merged by @mdvacca in 19faf7e When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed multiple lint warnings in NativeViewHierarchyManager.java:
ClownyBooleanExpression: Added SuppressLint for intentionally disabled
DEBUG_MODE (ReactBuildConfig.DEBUG && false). This pattern is used to
easily enable debug mode by changing to just ReactBuildConfig.DEBUG.
NullableAnnotationShouldNotAddToPrimitiveTypes: Removed Nullable from
getInstanceHandle() which returns a primitive long. Primitives can't be
null; this method throws exceptions instead of returning null.
NotInvokedPrivateMethod: Removed unused private methods arrayContains()
and getReactContextForView() which were dead code.
changelog: [internal] internal
Reviewed By: alanleedev
Differential Revision: D91992935